Emulator Issues #9416
closed
Up One level button crash
0%
Description
What's the problem? Describe what went wrong.
Trying to add my library location as an SD card on Nvidia Shield TV, on the browser when trying to go up one level from the internal storage Dolphin Crashes
What steps will reproduce the problem?
1.) Launch Dolphin
2.) Navigate to Add Folder
3.) if on newer version, click on overflow icon
4.) select up one level
5.) observe App Crash
Which versions of Dolphin did you test on? Does using an older version of Dolphin solve your issue? If yes, which versions of Dolphin used to work?
4.0-8723, 8820, 8863, 8877
What are your PC specifications? (CPU, GPU, Operating System, more)
Nvidia Shield TV 2015, Shield OS 3 (Android 6)
Is there any other relevant information? (e.g. logs, screenshots,
configuration files)
If there is a location where i could get a stack trace dump to upload let me know
Updated by BhaaL over 8 years ago
It sounded kinda obvious to me, but I just checked - it happens when you hit "Up one level" on /
03-12 13:16:08.974 11182 11182 E AndroidRuntime: Process: org.dolphinemu.dolphinemu, PID: 11182
03-12 13:16:08.974 11182 11182 E AndroidRuntime: java.lang.NullPointerException: Attempt to invoke virtual method 'java.io.File[] java.io.File.listFiles()' on a null object reference
03-12 13:16:08.974 11182 11182 E AndroidRuntime: at org.dolphinemu.dolphinemu.adapters.FileAdapter.generateFileList(FileAdapter.java:161)
03-12 13:16:08.974 11182 11182 E AndroidRuntime: at org.dolphinemu.dolphinemu.adapters.FileAdapter.upOneLevel(FileAdapter.java:203)
03-12 13:16:08.974 11182 11182 E AndroidRuntime: at org.dolphinemu.dolphinemu.activities.AddDirectoryActivity.onOptionsItemSelected(AddDirectoryActivity.java:83)
Updated by BhaaL over 8 years ago
- Status changed from New to Accepted
- Operating system Android added
- Operating system deleted (
N/A)
Updated by kagutsuchi over 8 years ago
Should be a relatively simple fix - use onPrepareOptionsMenu to hide/disable this MenuItem if currentDirectory.getParentFile() == null.
I haven't gotten around to setting up to build Dolphin yet. If this issue is still open then, I'll put a PR together.
Updated by JosJuice about 8 years ago
I vaguely remember this being fixed. Can someone confirm that?