Project

General

Profile

Actions

Emulator Issues #9559

closed

Move compatibility rating to game properties window or remove it

Added by Helios almost 8 years ago. Updated almost 6 years ago.

Status:
Fixed
Priority:
Low
Assignee:
% Done:

0%

Operating system:
N/A
Issue type:
Feature request
Milestone:
Regression:
No
Relates to usability:
No
Relates to performance:
No
Easy:
No
Relates to maintainability:
No
Regression start:
Fixed in:
5.0-6801

Description

So JosJuice and I were talking the other day about the gamelist and we realized that we could probably speed up scanning on startup a fair bit if we weren't hitting INIs for each game to check for compatibility ratings.

In my opinion, Dolphin is pretty dang good at emulating games to the point that a lot of the ratings are 4 or 5 stars, with a handful that are 3 or lower due to things we simply don't emulate yet. On top of that, I'm not sure the user really cares about that field? JMC said that the ratings are fairly accurate in his experience, but I don't feel they're a critical part of the main UI to have it be worth spending scanning time pulling all the ratings.

My proposal is we either move it to the game properties UI, or remove it. If we remove it I'd want confirmation from JMC and MaJoR that the wiki's ratings are relatively up to date.

This could be a nice scanning speed up for anybody with a large game library (Hi JMC.)

Obviously this will happen after 5.0, I don't want any significant UI changes this close to release.

Actions #1

Updated by Helios almost 8 years ago

  • Issue type changed from Bug to Feature request
Actions #2

Updated by JosJuice almost 8 years ago

  • Status changed from Accepted to New
  • Relates to performance changed from Yes to No
  • Easy changed from Yes to No

The reason I suggested removing emulation ratings was because I don't think there's much point in having emulation ratings in Dolphin, not because of performance benefits. If you want to skip reading INIs when reading the game list, you would also need to drop the feature to read custom names from INIs. I'm not sure how much the performance impact is right now, and the performance impact should get smaller if we put everything in one file instead of thousands in the future. Would it be worth it?

Unmarking as Easy since the decision on whether we should do this is complicated. Also unmarking as Relates to performance because the performance impact is unknown and Relates to performance generally is used for issues about emulation performance.

Actions #3

Updated by Helios almost 8 years ago

  • Status changed from New to Won't fix

Oh. I forgot about custom names in INIs. Never mind then. I don't want to remove that as I know some users use that. I imagine Netplay smashers do too.

Actions #4

Updated by JosJuice almost 8 years ago

  • Status changed from Won't fix to New

The reasons to remove emulation ratings that aren't about performance are still valid.

Actions #5

Updated by Mikemk almost 8 years ago

I find them useful. If they are removed, please make it an option to keep them.

Actions #6

Updated by JosJuice almost 6 years ago

  • Status changed from New to Fixed
  • Fixed in set to 5.0-6801
Actions

Also available in: Atom PDF