Emulator Issues #967
closedWii games has cracky sound after rev 2932 (and possible fix!)
0%
Description
What steps will reproduce the problem?
- After r2932 i have cracky noisy sound in several Wii Games
2.
3.
The 2932'th commit is mostly cool but,
The problem is in the Source\Core\Core\HW\DSP.cpp
and here's the patch file
Updated by XTra.KrazzY over 15 years ago
the check should be if the position is larger than the GC ARAM size, not than the mask
Updated by death2droid over 15 years ago
Should it be more like this?
if (_iAddress > ARAM_SIZE)
_iAddress = (_iAddress & ARAM_MASK);
return g_ARAM[_iAddress];
Updated by Autoran1 over 15 years ago
Tried your code, the sound is cracky again
Updated by death2droid over 15 years ago
Well it defiantly shouldn't be
if (_iAddress > WII_MASK)
_iAddress = (_iAddress & WII_MASK);
return g_ARAM[_iAddress];
Try
if (_iAddress > ARAM_SIZE)
_iAddress = (_iAddress & WII_MASK);
return g_ARAM[_iAddress];
Updated by nakeee over 15 years ago
WII_MASK is what was there before, and though I agree it's a bit weird.
I think we should ask ector why he changed those lines.
Updated by Autoran1 over 15 years ago
second one
if (_iAddress > ARAM_SIZE)
_iAddress = (_iAddress & WII_MASK);
return g_ARAM[_iAddress];
Updated by XTra.KrazzY over 15 years ago
Yeah it looks good. I think it's something that could be committed.
Updated by sl1nk3.s over 15 years ago
hmm, strange nobody committed it yet ?
changing return g_ARAM[_iAddress & ARAM_MASK];
to either return g_ARAM[_iAddress & WII_MASK];
or return g_ARAM[_iAddress]; without mask fix this
Updated by jhonatan.teixeira over 15 years ago
yeah this issue is fixed by death2droid =P
Updated by sl1nk3.s over 15 years ago
yeye, the thing has been reverted, but we still need to make sure this is the good
way to do it :)
Updated by death2droid over 15 years ago
Well what was the point of the aram_mask anyway?
Updated by daws72 over 15 years ago
Wii sports don't have anymore craky sound. :)