Project

General

Profile

Actions

Emulator Issues #9834

closed

[Android] scmrev.h isn't updated when building

Added by JosJuice over 7 years ago. Updated about 5 years ago.

Status:
Fixed
Priority:
Normal
Assignee:
-
% Done:

0%

Operating system:
Android
Issue type:
Bug
Milestone:
Regression:
Yes
Relates to usability:
No
Relates to performance:
No
Easy:
No
Relates to maintainability:
No
Regression start:
5.0-995
Fixed in:

Description

What's the problem? Describe what went wrong.

scmrev.h isn't updated when building for Android, meaning Dolphin can display the wrong version number when running.

What steps will reproduce the problem?

  1. Build Dolphin.
  2. Build a different version of Dolphin.
  3. You can now see that the new version of Dolphin claims to have the version number of the old version.

This happens both locally and on the buildbot.

Which versions of Dolphin did you test on? Does using an older version of Dolphin solve your issue? If yes, which versions of Dolphin used to work?

Broken by 5.0-995. https://github.com/dolphin-emu/dolphin/commit/f028b7079e1a9b3e3a7ef8f78e54fca315643ef1

Actions #1

Updated by JosJuice about 7 years ago

  • Status changed from New to Accepted
  • Priority changed from High to Normal

Apparently improved but not fully fixed by 5.0-2361. https://dolphin-emu.org/download/dev/bdf09c7d3bc5a22b562ce0f51400090b13ea8879/

EDIT: degasus says that isn't the case.

Actions #2

Updated by JosJuice about 5 years ago

  • Status changed from Accepted to Fixed

I can't recall this happening lately.

Actions

Also available in: Atom PDF