Project

General

Profile

Actions

Emulator Issues #11728

closed

FIFO Player crashing Dolphin While trying to play a recording

Added by jpapetti0713 almost 5 years ago. Updated almost 5 years ago.

Status:
Fixed
Priority:
Normal
Assignee:
% Done:

0%

Operating system:
FreeBSD, Linux, OS X
Issue type:
Bug
Milestone:
Current
Regression:
Yes
Relates to usability:
No
Relates to performance:
No
Easy:
No
Relates to maintainability:
No
Regression start:
5.0-10172
Fixed in:
5.0-10609

Description

Game Name?

ANY

Game ID? (right click the game in the game list, Properties, Info tab)

ANY

MD5 Hash? (right click the game in the game list, Properties, Verify tab, Verify Integrity button)

ANY

What's the problem? Describe what went wrong.

FIFO player will not replay any saved recordings of a game.

What steps will reproduce the problem?

  1. Open a game
  2. Record from FIFO Player
  3. Save
  4. Try to load recording
  5. Crashes

Is the issue present in the latest development version? For future reference, please also write down the version number of the latest development version.

Yes ,as of 5.0-10200

Is the issue present in the latest stable version?

I don't think so.

If the issue isn't present in the latest stable version, which is the first broken version? (You can find the first broken version by bisecting. Windows users can use the tool https://forums.dolphin-emu.org/Thread-green-notice-development-thread-unofficial-dolphin-bisection-tool-for-finding-broken-builds and anyone who is building Dolphin on their own can use git bisect.)

???

If your issue is a graphical issue, please attach screenshots and record a three frame fifolog of the issue if possible. Screenshots showing what it is supposed to look like from either console or older builds of Dolphin will help too. For more information on how to use the fifoplayer, please check here: https://wiki.dolphin-emu.org/index.php?title=FifoPlayer

N/A:

What are your PC specifications? (CPU, GPU, Operating System, more)

  1. MacBook Pro (Retina, 13-inch, Mid 2014), 2.6 GHz Intel Core i5, RAM: 16 GB 1600 MHz DDR3, Video: Intel Iris 1536 MB, running MacOS High Sierra 10.13.6 (17G5019).
  2. MacBook Pro (Retina, 13-inch, 2017, Four Thunderbolt 3 Ports), 3.1 GHz Intel Core i5, RAM: 8 GB 2133 MHz DDR3, Video: Intel Iris Plus Graphics 650 1536 MB, running MacOS Mojave 10.14.5 Beta (18F96h).

Is there anything else that can help developers narrow down the issue? (e.g. logs, screenshots,
configuration files, savefiles, savestates)

Windows does not seem to have a problem with this issue, only MacOS.

I will try to provide logs from MBP Mojave.

Terminal reports: Segmentation fault: 11

Switching to Vulkan, OpenGl, Software Renderer will not help.


Files

log.txt (57.1 KB) log.txt jpapetti0713, 05/13/2019 11:27 AM
Dolphin_2019-05-13-073022_Johns-MacBook-Pro-2.crash (65.1 KB) Dolphin_2019-05-13-073022_Johns-MacBook-Pro-2.crash jpapetti0713, 05/13/2019 11:32 AM
Stack trace.txt (4.15 KB) Stack trace.txt chargeflux, 05/13/2019 04:05 PM
Actions #2

Updated by JMC4789 almost 5 years ago

Fifoplayer is working for me... so potentially mac only issue?

Actions #3

Updated by jpapetti0713 almost 5 years ago

Yeah, it's a Mac only issue. Windows is fine.

Actions #4

Updated by chargeflux almost 5 years ago

I have not done a full bisect but I checked the commit before and Fifoplayer works fine. This commit https://github.com/dolphin-emu/dolphin/commit/123bbbca2c3382165cf58288e4d65d0974a9c0db causes the crash. I attached a stack trace.

Actions #5

Updated by jpapetti0713 almost 5 years ago

Still not resolved, as of 10607...

On inspecting the code, I noticed that OnFrameEnd() in Core is a function that is only used by Memory Watcher.

I believe that s_memory_watcher->Step(); is the culprit that keeps crashing Dolphin on MacOS.

I suggest disabling s_memory_watcher->Step(); in OnFrameEnd() on MacOS in order to get FIFO Player to work again.
(I can post a PR with a fix if needed)

Actions #6

Updated by JosJuice almost 5 years ago

  • Status changed from New to Accepted
  • Assignee set to JosJuice
  • Milestone set to Current
  • Regression changed from No to Yes
  • Regression start set to 5.0-10172
Actions #7

Updated by JosJuice almost 5 years ago

  • Operating system FreeBSD, Linux, OS X added
  • Operating system deleted (N/A)
Actions #8

Updated by jpapetti0713 almost 5 years ago

Excellent, thanks a lot!

Actions #9

Updated by JosJuice almost 5 years ago

  • Status changed from Accepted to Fixed
  • Fixed in set to 5.0-10609
Actions

Also available in: Atom PDF