Project

General

Profile

Actions

Emulator Issues #12553

closed

Performance regression with Pokemon Battle Revolution after pr#9702

Added by ds22x over 3 years ago. Updated over 3 years ago.

Status:
Duplicate
Priority:
Normal
Assignee:
-
% Done:

0%

Operating system:
N/A
Issue type:
Bug
Milestone:
Regression:
No
Relates to usability:
No
Relates to performance:
No
Easy:
No
Relates to maintainability:
No
Regression start:
Fixed in:

Description

Game Name?

Pokemon Battle Revolution

Game ID? (right click the game in the game list, Properties, Info tab)

RPBE01

MD5 Hash? (right click the game in the game list, Properties, Verify tab, Verify Integrity button)

ea3ad19c1e0d671a26f056d8cb51eeb7

What's the problem? Describe what went wrong.

Ever since pr#9702 has been merged, Dolphin will slow down significantly when having a Pokemon battle and during the first island transition.
I've also noticed some audio crackling when saving the game in Pokemon Colosseum, but the performance drop is way more noticeable in PBR.

What steps will reproduce the problem?

Load the game and start a Pokemon battle.

Is the issue present in the latest development version? For future reference, please also write down the version number of the latest development version.

Yes. 5.0-14435

Is the issue present in the latest stable version?

No. 5.0-14344

If the issue isn't present in the latest stable version, which is the first broken version? (You can find the first broken version by bisecting. Windows users can use the tool https://forums.dolphin-emu.org/Thread-green-notice-development-thread-unofficial-dolphin-bisection-tool-for-finding-broken-builds and anyone who is building Dolphin on their own can use git bisect.)

5.0-14382

If your issue is a graphical issue, please attach screenshots and record a three frame fifolog of the issue if possible. Screenshots showing what it is supposed to look like from either console or older builds of Dolphin will help too. For more information on how to use the fifoplayer, please check here: https://wiki.dolphin-emu.org/index.php?title=FifoPlayer

What are your PC specifications? (CPU, GPU, Operating System, more)

Intel Core i5-9300H, Nvidia GTX 1650, Windows 10 20H2.

Is there anything else that can help developers narrow down the issue? (e.g. logs, screenshots,
configuration files, savefiles, savestates)


Related issues 1 (0 open1 closed)

Is duplicate of Emulator - Emulator Issues #12558: MGS Twin Snakes performance regression since 5.0-14382Fixed

Actions
Actions #1

Updated by JMC4789 over 3 years ago

It's probably some stupid thing to do with the Wii Remote pointer sometimes being slow.

Actions #2

Updated by ds22x over 3 years ago

I'm kinda confused how that would cause such a hit in performance (from 60fps to like 50fps at best and 25fps at worst).
I'm also using an emulated controller profile for a sideways Wiimote.

Actions #3

Updated by JMC4789 over 3 years ago

If you have access to compiling and taking performance metrics, you could check and see what the new hot path is.

Actions #4

Updated by filoppi over 3 years ago

Could I have your full controller profile?
Make sure you disable all other controllers (e.g. Wiimote 2, GC pad 1/2/3/4) and disconnect all your controllers from the computer (e.g. xbox controllers, DS3/DS4, ...), just exclusively map the keyboard to the controller,
see if the performance are still regressed, if not, try to re-enable emulated and physical controller in steps and maybe find what slows it down?

Actions #5

Updated by filoppi over 3 years ago

The fact that the game only slows down during certain scenes might just be cause they are the harder scenes to handle by the emulation, because my code should not touch within the emulation, unless the game is forcefully triggering wiimote disconnections, which I don't know if it's even possible.
If you are sure the slowdowns were caused by my PR, it might just be because of some device that is constantly adding and removing itself due to a faulty USB.
Due to the additional thread safety I put in, some things might be slightly slower, while other should be faster.

Actions #6

Updated by ds22x over 3 years ago

This issue can be marked as invalid.
Turns out a corrupted shader was causing the showdowns, and a complete reinstall of Dolphin fixed it (that, and afterwards I tried the backup "broken" build, deleted the cache folder, and it too worked again).
Sorry for any inconvenience I may have caused.

Actions #7

Updated by JosJuice over 3 years ago

  • Status changed from New to Invalid

That's odd, but alright, I'll close the issue.

Actions #8

Updated by JosJuice over 3 years ago

Actions #9

Updated by JosJuice over 3 years ago

Actions #10

Updated by JosJuice over 3 years ago

  • Status changed from Invalid to Duplicate
Actions #11

Updated by JosJuice over 3 years ago

Actions

Also available in: Atom PDF