Project

General

Profile

Actions

Emulator Issues #13103

closed

New problem Update message error !

Added by Cricri over 1 year ago. Updated 9 days ago.

Status:
Fixed
Priority:
Normal
Assignee:
-
% Done:

0%

Operating system:
N/A
Issue type:
Bug
Milestone:
Regression:
No
Relates to usability:
No
Relates to performance:
No
Easy:
No
Relates to maintainability:
No
Regression start:
Fixed in:

Description

Hello,
New update problem, and on both PCs!
And this time it is impossible to restart the application except by refusing the update. Yesterday or before yesterday, it worked!
Cdt,


Files

Actions #2

Updated by Anonymous over 1 year ago

can you post the Updater.log file?

You should be seeing another dialog pop up, which installs the latest VC++ redist. Either you are clicking "no" on that dialog, or it fails for some other reason...

Actions #3

Updated by Cricri over 1 year ago

godisgovernment wrote in #note-2:

can you post the Updater.log file?

You should be seeing another dialog pop up, which installs the latest VC++ redist. Either you are clicking "no" on that dialog, or it fails for some other reason...

The updater.log file is empty !

Actions #4

Updated by Cricri over 1 year ago

For the moment I directly downloaded the last version. To see later if the updates pass. Finally there is always the other computer to continue testing on the older version. FYI, I have Windows 10 22H2

Actions #5

Updated by Anonymous over 1 year ago

Check for Dolphin Emulator\Logs\Updater.log in e.g. %USERPROFILE%\Documents (or wherever dolphin user files are stored for you).

The empty Updater.log is another bug we should probably fix.

Are you running dolphin in portable mode (portable.txt)?

Actions #6

Updated by Cricri over 1 year ago

No in portable mode.
In portable mode moreover, too much slowdown so abandoned!

Found in default folder USER%.....

Updating from: https://update.dolphin-emu.org/manifest/win/f2/8e/5607fec604f998994e5d65931707eafec841.manifest
Updating to: https://update.dolphin-emu.org/manifest/win/d7/59/3dd7215d92ea0b5eb8fa8b592f3ed758b2ea.manifest
Install path: G:\Emulateurs\Nintendo\Dolphin-x64
Waiting for parent PID 20072 to complete...
Completed! Proceeding with update.
Updating:

Actions #7

Updated by Anonymous over 1 year ago

Thanks, unfortunately it doesn't show much interesting new information.

Could you take a procmon trace again when the problem happens?

Actions #8

Updated by Cricri over 1 year ago

Yes on occasion, if the problem recurs with this PC, otherwise on another PC which I don't use as an emulator but just to do the bug tests, I have the same thing. However, I did not check the file above. Sorry, for my English, I go through a translator!

Actions #9

Updated by Cricri over 1 year ago

In other PC !

Updating from: https://update.dolphin-emu.org/manifest/win/43/13/01add36f455f8667e3118f9365b6309eeeac.manifest
Updating to: https://update.dolphin-emu.org/manifest/win/d7/59/3dd7215d92ea0b5eb8fa8b592f3ed758b2ea.manifest
Install path: D:\Dolphin-x64
Waiting for parent PID 6828 to complete...
Completed! Proceeding with update.
Updating:

Actions #10

Updated by Anonymous over 1 year ago

Please post a procmon trace.

Actions #11

Updated by Cricri over 1 year ago

godisgovernment wrote in #note-10:

Please post a procmon trace.

At this time, the problem does not occur again since the direct download from the last time. But on the other PC I left original to have the problem.

https://drive.google.com/file/d/1o7yMEq0d_JdTSUWV6L4yKYuKmRCDom1U/view?usp=share_link

Actions #12

Updated by Anonymous over 1 year ago

If you look here:

this relates to GetInstalledVCRuntimeVersion being called twice https://github.com/dolphin-emu/dolphin/blob/master/Source/Core/WinUpdater/Platform.cpp#L159

so, the check correctly determines the vc++ runtime is too old, however in between the two calls, we should also see a download of https://aka.ms/vs/17/release/vc_redist.x64.exe, writing it to file, and then executing it. Apparently it does not download for you (i.e. https://github.com/dolphin-emu/dolphin/blob/master/Source/Core/WinUpdater/Platform.cpp#L185 this return false is taken).

Do you have something configured on your PC that would block this download for some reason? Are you able to download https://aka.ms/vs/17/release/vc_redist.x64.exe manually?

MsMpEng.exe (Windows Defender) appearing here in the trace is suspicious. Have you messed with it so it's not operating correctly? Maybe it is blocking the download for some reason...

fwiw you can use Process Hacker to view Defender Firewall activity https://processhacker.sourceforge.io/downloads.php

Actions #13

Updated by Cricri over 1 year ago

godisgovernment wrote in #note-12:

If you look here:

this relates to GetInstalledVCRuntimeVersion being called twice https://github.com/dolphin-emu/dolphin/blob/master/Source/Core/WinUpdater/Platform.cpp#L159

so, the check correctly determines the vc++ runtime is too old, however in between the two calls, we should also see a download of https://aka.ms/vs/17/release/vc_redist.x64.exe, writing it to file, and then executing it. Apparently it does not download for you (i.e. https://github.com/dolphin-emu/dolphin/blob/master/Source/Core/WinUpdater/Platform.cpp#L185 this return false is taken).

Do you have something configured on your PC that would block this download for some reason? Are you able to download https://aka.ms/vs/17/release/vc_redist.x64.exe manually?

MsMpEng.exe (Windows Defender) appearing here in the trace is suspicious. Have you messed with it so it's not operating correctly? Maybe it is blocking the download for some reason...

fwiw you can use Process Hacker to view Defender Firewall activity https://processhacker.sourceforge.io/downloads.php

Hello. By downloading the runtime manually from this link, the installation goes very well. And then restarting the Dolphin update, it went (the only thing is that after the runtime update, it asks to restart the machine (something I didn't do), here still works.

Actions #14

Updated by Cricri over 1 year ago

godisgovernment wrote in #note-12:

If you look here:

this relates to GetInstalledVCRuntimeVersion being called twice https://github.com/dolphin-emu/dolphin/blob/master/Source/Core/WinUpdater/Platform.cpp#L159

so, the check correctly determines the vc++ runtime is too old, however in between the two calls, we should also see a download of https://aka.ms/vs/17/release/vc_redist.x64.exe, writing it to file, and then executing it. Apparently it does not download for you (i.e. https://github.com/dolphin-emu/dolphin/blob/master/Source/Core/WinUpdater/Platform.cpp#L185 this return false is taken).

Do you have something configured on your PC that would block this download for some reason? Are you able to download https://aka.ms/vs/17/release/vc_redist.x64.exe manually?

MsMpEng.exe (Windows Defender) appearing here in the trace is suspicious. Have you messed with it so it's not operating correctly? Maybe it is blocking the download for some reason...

fwiw you can use Process Hacker to view Defender Firewall activity https://processhacker.sourceforge.io/downloads.php

Hello. By downloading the runtime manually from this link, the installation goes very well. And then restarting the Dolphin update, it went (the only thing is that after the runtime update, it asks to restart the machine (something I didn't do), here still works.

Cricri wrote in #note-13:

godisgovernment wrote in #note-12:

If you look here:

this relates to GetInstalledVCRuntimeVersion being called twice https://github.com/dolphin-emu/dolphin/blob/master/Source/Core/WinUpdater/Platform.cpp#L159

so, the check correctly determines the vc++ runtime is too old, however in between the two calls, we should also see a download of https://aka.ms/vs/17/release/vc_redist.x64.exe, writing it to file, and then executing it. Apparently it does not download for you (i.e. https://github.com/dolphin-emu/dolphin/blob/master/Source/Core/WinUpdater/Platform.cpp#L185 this return false is taken).

Do you have something configured on your PC that would block this download for some reason? Are you able to download https://aka.ms/vs/17/release/vc_redist.x64.exe manually?

MsMpEng.exe (Windows Defender) appearing here in the trace is suspicious. Have you messed with it so it's not operating correctly? Maybe it is blocking the download for some reason...

fwiw you can use Process Hacker to view Defender Firewall activity https://processhacker.sourceforge.io/downloads.php

Hello. By downloading the runtime manually from this link, the installation goes very well. And then restarting the Dolphin update, it went (the only thing is that after the runtime update, it asks to restart the machine (something I didn't do), here still works.

On the other hand, I have the impression, if you follow the updates every day, it passes. On the other hand, if you have a slightly old version, without updating for a few days, that sometimes causes problems. Depending on the Windows updates, it also blocks. To believe that Microsoft blocks or secures more

Actions #15

Updated by Anonymous over 1 year ago

The problem will occur sporadically for you because the timing is related to when the toolchain on the buildbot is updated.

The problem is that on your PC(s), something is blocking Updater.exe when it attempts to download the file - or the download does not occur for some reason, in any case.

Actions #16

Updated by Cricri over 1 year ago

godisgovernment wrote in #note-15:

The problem will occur sporadically for you because the timing is related to when the toolchain on the buildbot is updated.

The problem is that on your PC(s), something is blocking Updater.exe when it attempts to download the file - or the download does not occur for some reason, in any case.

It's not systematic and not only on a single PC, so ...
Is it the Microsoft antivirus which blocks it? It's possible, I don't use any others, except CCleaner which also tends to... In any case, by downloading Dolphin directly onto a PC, it went straight through. There is an update which blocks compared to Dolphin I have the impression.

Actions #17

Updated by Anonymous over 1 year ago

In any case, by downloading Dolphin directly onto a PC, it went straight through

Yes but you should always install latest vc++ redist manually in this case. It is not guaranteed to work on old vc++ redist. Dolphin's updater makes sure it is up to date. But when you download and run Dolphin.exe the check doesn't occur.

Actions #18

Updated by Anonymous about 1 year ago

should be fixed in https://github.com/dolphin-emu/dolphin/commit/a6b2655631f4605cad45ed222dbce0bf72dc1722
the bug was that WriteLinesToFile ( https://learn.microsoft.com/en-us/visualstudio/msbuild/writelinestofile-task?view=vs-2022 ) appends a CRLF at the end of a file that is initially LF-only, and the extra CR happened to be parsed into the vc++ redist URL.

Actions #19

Updated by Cricri about 1 year ago

Hello,

In fact, I noticed that the bug occurs when you don't update for a long time.

Actions #20

Updated by Anonymous about 1 year ago

You will not notice the fix for a while. The fix is in this build https://dolphin-emu.org/download/dev/a6b2655631f4605cad45ed222dbce0bf72dc1722/ but won't be applicable until the next time vc++ redist version in increased (a few weeks/months)

Actions #21

Updated by Billiard26 9 days ago

  • Status changed from New to Fixed

No response from OP. Assuming fixed. Will re-open upon request.

Actions

Also available in: Atom PDF