Project

General

Profile

Actions

Emulator Issues #13515

closed

Dolphin does not build with Minizip-ng 4.0.4.

Added by brad 9 months ago. Updated 8 months ago.

Status:
Fixed
Priority:
Normal
Assignee:
-
% Done:

0%

Operating system:
N/A
Issue type:
Bug
Milestone:
Regression:
No
Relates to usability:
No
Relates to performance:
No
Easy:
No
Relates to maintainability:
No
Regression start:
Fixed in:
5.0-21443

Description

Dolphin does not build with Minizip-ng 4.0.4.

https://github.com/dolphin-emu/dolphin/commit/a5d06fde4b597d93750ba29bc2db83401fe431f7

Changed the last parameter to unzLocateFile() from 0 to NULL.

https://github.com/zlib-ng/minizip-ng/commit/6c5f265a55f1a12a7a016cd2962feff91cff5d2e

MZ_COMPAT_VERSION is not defined. unzFileNameCase is an int.

#if !defined(MZ_COMPAT_VERSION) || MZ_COMPAT_VERSION < 110
ZEXPORT int     unzLocateFile(unzFile file, const char *filename, unzFileNameCase filename_case);
#else
ZEXPORT int     unzLocateFile(unzFile file, const char* filename, unzFileNameComparer filename_compare_func);
#endif
/home/ports/pobj/dolphin-5.0.0.20230722/dolphin-5.0.0.20230722/Source/Core/UICommon/ResourcePack/ResourcePack.cpp:39:7: error: no matching function for call to 'unzLocateFile'
  if (unzLocateFile(file, "manifest.json", nullptr) == UNZ_END_OF_LIST_OF_FILE)
      ^~~~~~~~~~~~~
/usr/local/include/minizip/mz_compat.h:364:17: note: candidate function not viable: no known conversion from 'std::nullptr_t' to 'unzFileNameCase' (aka 'int') for 3rd argument
ZEXPORT int     unzLocateFile(unzFile file, const char *filename, unzFileNameCase filename_case);
                ^
/home/ports/pobj/dolphin-5.0.0.20230722/dolphin-5.0.0.20230722/Source/Core/UICommon/ResourcePack/ResourcePack.cpp:66:7: error: no matching function for call to 'unzLocateFile'
  if (unzLocateFile(file, "logo.png", nullptr) != UNZ_END_OF_LIST_OF_FILE)
      ^~~~~~~~~~~~~
/usr/local/include/minizip/mz_compat.h:364:17: note: candidate function not viable: no known conversion from 'std::nullptr_t' to 'unzFileNameCase' (aka 'int') for 3rd argument
ZEXPORT int     unzLocateFile(unzFile file, const char *filename, unzFileNameCase filename_case);
                ^
2 errors generated.

Related issues 1 (0 open1 closed)

Related to Emulator - Emulator Issues #13169: Compilation error on Fedora Linux - minizip vs minizip-ngFixed

Actions
Actions

Also available in: Atom PDF