Project

General

Profile

Actions

Emulator Issues #2240

closed

Direct3D EFB scaled copy is not 100% upscaled

Added by jayork42 over 14 years ago.

Status:
Fixed
Priority:
Normal
Assignee:
-
% Done:

0%

Operating system:
N/A
Issue type:
Bug
Milestone:
Regression:
No
Relates to usability:
No
Relates to performance:
No
Easy:
No
Relates to maintainability:
No
Regression start:
Fixed in:

Description

What steps will reproduce the problem?

  1. Start a game that uses EFB copy for the entire screen
  2. Enable the D3D plugin and enable EFB scaled copy
    3.

What is the expected output? What do you see instead?
The image is supposed to appear at the same resolution as the main buffer.
Instead it looks slightly jagged, like it's at a lower resolution than the
plugin setting.

What version of the product are you using? On what operating system?
SVN R5000 WinXP Pro MCE x86

Please provide any additional information below.
I'm not sure this is valid since it seems to happen at 640x480 with EFB
scaled copy off as well, but I believe it's worth looking into.

~Screenshots
http://i50.tinypic.com/2dgq5vm.png
http://i46.tinypic.com/2up7rkp.png

Actions #1

Updated by sl1nk3.s over 14 years ago

  • Status changed from New to Questionable

Hmm, i fail to see the exact issue here, you seem to be referring to the internal
resolution which is not exactly the one chosen in the plugin setting (as i fail to
see anything obviously related to EFB copy in those screenshots).
If that's what the issue is about, well unfortunately most games don't render at the
exact resolution of "640x480" on the real HW, so we have to slightly rescale the
image to fit the screen which might cause the jaggies you see and explains why it
also happens on native res :D

Actions #2

Updated by jayork42 over 14 years ago

If that's the case, then that makes sense. It just struck me as odd that the image
looked lower-res than the actual video setting. I guess this has nothing to do with
EFB copy at all? Probably antialiasing by my video card, as I don't have AA turned on
anywhere in Dolphin.

Actions #3

Updated by jayork42 over 14 years ago

Here's a close look. Notice the edges take up 2 lines instead of 1.From a 1:1
perspective it's hard to tell if it's AA or just a reduced resolution.

http://i46.tinypic.com/2dj1gmx.png

Actions #4

Updated by Line524 over 14 years ago

Yeah,EFB copy really need to be propertly upscaled ! Monster Hunter 3 also have those
jagging problem. But the biggest problem is that EFB copy layer have some incorrect
displacement nd it causing EFB bloom problems.
There is a patch here, that solves this problem:
http://forums.dolphin-emu.com/attachment.php?aid=3125

Actions #5

Updated by skidau about 14 years ago

  • Status changed from Questionable to Fixed

Ticking the EFB Scaled Copy option and setting the Internal Resolution to something other than native fixes this problem.

Actions

Also available in: Atom PDF