Emulator Issues #3466
closed
Xfb changes in r6304 break "Fragile dreams" and "Another Code R" that depend upon it to function properly.
Added by kostamarino about 14 years ago.
Relates to performance:
No
Relates to maintainability:
No
Description
What steps will reproduce the problem?
1.Play either "Fragile Dreams" or "Another Code R" for Wii with XFB enabled. After both games start you are introduced to flickering that should have been eliminated by enabling XFB.
2.
What is the expected output? What do you see instead?
No flickering instead you get flickering
Dolphin version with the problem? Other Dolphin version without the
problem?
r6354 has the issue while r6303 doesn't
32-bit or 64-bit and any other build parameters?
64 bit
OS version and versions of tools/libraries used?
win7 64bit pro
Please provide any additional information below.
- Status changed from New to Accepted
Would you please try copying the video plugin from r6303 into a r6304 installation? Let me know if using the r6304 exe with the r6303 dll's fixes the problem. If it does not, please confirm that using the r6303 exe with the r6304 dll's works.
Using r6303 .dll's fixes it here.
Ok, thanks. I guess we don't need to worry about the e-mails or special builds anymore. I have enough information to fix this problem.
- Status changed from Accepted to Fixed
This issue was closed by revision r6360.
kosta, would you please test these two games in Single Core mode and let me know the results?
Damn, i tested them both and i found out that while their behavior is the same no matter if dual core is enabled or not, one of them (Fragile dreams) seems to be still broken with 6360, i was quick to judge. It has less flickering than before but it is still there and it is quite annoying(with or without dual core being enabled). The other game on the other hand(Another code R) is fixed (single or dual core enabled is the same).
Would you please test Fragile Dreams with r6359 just to make sure that r6360 made no difference? Also, toggle the progressive scan setting in your tests, but this time the single core test will be unnecessary.
Just noticed that you didn't completely revert 6304 and that seems to be the reason of the flickering of Fragile dreams. Using 6303 video plugin works again.
ok, I'll talk to the other devs and discuss whether it should be fully reverted. The part of the code that I didn't put back looked wrong (the code doesn't make much sense). Please be real sure that r6303 fixes it completely for Fragile Dreams.
Actually, the other change resides in the exe. So it doesn't make sense that r6303 works while r6360 doesn't. Both video plugins should contain the same code now (for this area).
Sorry skidau for the late answer. Progressive scan also seems to fix it (no need to use an old plugin), while it wasn't needed for past plugins and dolphin versions. Btw my plugin swap was with r6285 not 6303 that worked fine without progressive scan enabled(was a bit lazy there). So i guess 6360 is fine as it is, it is just a matter of proper configuration. Unfortunately you can't configure progressive scan in per game settings though any more.
This issue isn't fixed on r7128. With progressive scan and xfb(real or virtual) enabled the flickering is bearable but still present at regular intervals. Turning xfb off makes it worse.
Also available in: Atom
PDF