Emulator Issues #4316
closed
Frame dumping in full screen only dumps part of screen (Windows)
Added by vojin.djekic over 13 years ago.
Relates to performance:
No
Relates to maintainability:
No
Description
What's the problem?
"Dump Frames" option is broken. Video resolution is incorrect. Look at the pictures...
Dolphin version with the problem (as it appears in the title bar, Ex.: "R
4779" or "R 6403M"):R7405
(optional) Dolphin version that does not have the problem:R7005
Operating system and version: Win7 Ultimate
32-bit or 64-bit:64
Game ID (as it appears in game properties, Ex.: "GZ2P01" or "RSBE01"):
it's broken in every game.
Build command-line (not on Windows):
Was the ISO a plain dump from disc, compressed and/or scrubbed?
plain dump
Please provide any additional information below.
this was broken somewhere between r7005 and r7405.
Does this occur with all video backends, or just the DX9 backend?
Does it occur if you have auto window size selected?
By any chance, is it fine after r7388 but broken again by r7410?
Because I think I know why it's happening if so, though I'm not sure how to fix it... other than setting fullscreen resolution to the same as windowed resolution.
-it occurs with all video backends (don't know about software renderer)
-it seems that dx11 doesn't doesnt work at all
-auto window size doesn't help
-if i set widowed resolution=full screen resolution i get slightly less resolution than the full screen resolution (because of window borders, since they can go off screen, i hope you understood me :) ).
-it's not broken again by 7410 since it doesn't work with 7405
Sorry, i meant that borders CAN'T go off screen (not CAN).
Ah, yeah, missed that. Just reminds me of a problem I'm getting with something. I need to change both the full screen resolution and windowed resolution to make 3D work. With my problem, it's happening because Dolphin actually starts up with the windowed resolution, then quickly changes to fullscreen resolution. Thought it might be related.
Do you get the problem in windowed mode? Seems to be fine for me. I've got a few edits on my build at the moment though, so I thought I'd ask.
Widowed mode works perfectly, i was also thinking what you just sad. problem is, dolphin starts windowed mode, then frame dumping, then switches to full screen, so dumping breaks.
Is it possible to change the order of these things, i mean, to start dumping (or 3D), after checking if dolphin needs to go full screen on start up?
This appears to be a Windows-specific bug (at least, it doesn't occur under Linux)
Now that you mention that, I just remembered something. While I was trying to narrow down why Dolphin was starting with the wrong resolution in fullscreen mode, I had a look through various commits, and I found that some recent changes to RenderWindowSize in Frame.ccp may have been causing it.
In fact, if I remember right, if you remove the "#ifdef WXGTK", you get the right resolution at startup (but it crashes pretty much instantly afterwards). I have no idea what that bit of code does, so I dunno, might not be related, but I thought I'd mention it.
Annoyingly, I can't actually test if I remember right at the moment, I'm on a rubbish little netbook, even if it could run Dolphin, I don't have VS2010 on it.
smelenchuck: This is not a windows specific bug. It occurs on linux as well. Anytime that the window size is changed after emulation is started the video ends up either the way that vojin describes, or worse. The window size can be changed after emulation starts when changing to fullscreen (which happens if "Start Render in Fullscreen" is selected), or by using the auto size option. There are of course other ways that the window size can be changed.
is it possible to write a piece of code that will check if "Start Render in Fullscreen" option is selected? if it's not selected, widowed mode already works, so there's no problem in that case. But, if FS option is selected, do some sort of checking, and start dumping after starting FS? I'm just trying to give you an idea, I don't know much about dolphin coding. I'll try to find exact revision that broke this...
This was broken somewhere between r7185(fine) and r7190(broken), i can't tell you the exact revision, since there aren't any revisions in between available for download.
Hi! This is partly fixet in Dolphin r7412.
- Issue type set to Bug
- Category set to gfx
- Operating system Windows added
- Status changed from New to Questionable
Is this issue present in Dolphin 3.5 or later?
It is in dumb situations like resizing the window after you start dumping. I've never had it happen otherwise.
- Status changed from Questionable to Won't fix
This doesn't happen when set to start in full screen. It only happens with auto adjust window size, or if you manually change the window size/fullscreen while dumping frames. There's now an error message given if you do that. So don't do it. If you do, you deserve whatever happens to your video.
Also available in: Atom
PDF