Emulator

Should I post the patch proposal in 4185 issue?

Only if it works for Windows;-)

I will be pleased to make it compile under windows if you gave me a VisualStudio licence ;-)

I marked it as a duplicate, which is as close as googlecode gets to "merging" issues. You do not need to repost it.

I'll check it out on windows when i get some time, patch looks ok though.
note: perhaps in the future only make patches of the actual change, not formatting changes...they just make it hard to read :p

As for VS, you can get the express version, or download a trial of any of the other versions. Or you could just not bother, up to you.

Sorry for the formatting change, I am used to have my code autoformated under eclipse.

I just discovered in the wiki that I could get VS express.
I am downloading it so I can make it compile under windows.

So if you haven't tried it yet, it seems like your patch has a race condition that hangs/crashes dolphin on windows. I haven't debugged it yet, just letting you know that I tried it at least.

Thanks for telling me.
I am trying to compile it under virtualbox, but it take time to setup everything.

What kind of race do you observe? Is it systematical?

Here is your patch with the unrelated formatting changes removed. Unfortunately the formatting changes in the new code are still there...

Probably won't get a chance to debug the problem until the end of the day (morning where I'm at :p).

Ah well, the issue was somewhere in your changes to CoreTiming.h/cpp, so I just reverted all of them. No crash now.

However, audio does not sound correct, so at the moment this is not an acceptable patch.

fwiw (if you didn't pick it up from comments in the source) audio must be sent at 5-7ms intervals (or, 20ms/3packets=6.66667ms).

Ok CoreTiming.h/cpp is not mandatory. As I explained it in the first post, I pushed it because I use it but it is not directly related to the wiimote issue. You did well to remove it.

Could you be more specific when you say audio As I did not touch any audio file? It is about the the WII speaker?

wiiMOTE speaker specifically ;p

yes, the whole cause behind the "spurious" disconnects is that some games (epic mickey, dkcr, just dance 2) send a continuous stream of empty audio data to the wiimote. With the current code in svn, this effectively overloads the wiimote (it spends all it's time receiving, and not sending any status reports) which causes the emulated game to think the wiimote has vanished.

...and the cause behind the cause, so to speak, is that timing the reports such that they are sent at ~5ms is too much to ask of most desktop operating systems.

Ok I did not notice any difference under linux. The sound on the wiimote was crappy with or without this patch :D

I am a bit puzzled by your explanation. If we were overloading the wiimote, this patch would not change anything.

I think the issue is more that the loop, as it is written, does not allow us to keep up with the report flow. We certainly miss some reports and the application believes that the wiimote is disconnect.

Having two threads in the patch, one to read and the other to send allows us to keep up with the continues flow.

The sending thread sends a packet (if not empty) as soon as it receives it. There is no time regulation, but I guess would could had something in the write loop to improve this.

This is a new version of the patch taking into account all your advices.
It compile fine under windows, but I could not test it under my VM.

could you give it a try?