Project

General

Profile

Actions

Emulator Issues #5252

closed

Save states unstable in some games with Dual Core enabled

Added by wespipes69 over 12 years ago.

Status:
Fixed
Priority:
Normal
Assignee:
-
% Done:

0%

Operating system:
N/A
Issue type:
Bug
Milestone:
Regression:
No
Relates to usability:
No
Relates to performance:
No
Easy:
No
Relates to maintainability:
No
Regression start:
Fixed in:

Description

  1. Game Name and ID (as it appears in right click > properties: "GZ2P01",
    "RSBE01", etc):
    Mario Golf GFTE01

2) What is the expected output? What do you see instead?
Game crashes >90% of the time when loading a save state. If it does actually work, it takes about 10-15 sec. to load. But if using Single Core, save states are 100% rock solid and fast.

3) Did the game ever work correctly (i.e. not have this problem) on an
earlier version of dolphin? Please specify the exact revision when the
problem began.
Unsure, states are a lot more stable on recent builds. Using 3.0-427

4) What steps will reproduce the problem?

  1. Enable Dual Core (default)
  2. Launch Mario Golf (unsure if this occurs on other titles)
  3. Reach in game and start using save states. The game will freeze usually upon trying to load the state.
  4. If you relaunch the game and load the state it usually DOES load fine. But after that it'll cause a freeze - (0 fps 60 vps 100% speed).

5) What version of dolphin are you using (32bit/64bit along with the
version as it appears in the title bar, etc)? Do not say 'latest version'
this changes multiple times a day.
On what operating system, drivers, and hardware? Be sure to list OS,
graphics driver information, and video card model if you are having
graphics problems, for example.
Win7 x64

Let me know if there's anything else I can do to help troubleshoot this. Mario Golf as you know has plenty of issues and does need LLE for background music, meaning playing without DC makes the game unplayable if you want to have descent music. Hopefully you guys can sort this out!

Actions #1

Updated by rdragoon over 12 years ago

I believe this has been fixed for a while now in the more-save-fixes branch.

Actions #2

Updated by wespipes69 over 12 years ago

Oh, I thought that was already integrated into main. Is there a build of that anywhere?

Actions #3

Updated by skidau over 12 years ago

This TAS Input branch has those changes integrated:

http://www.emucr.com/2012/01/dolphin-tas-input-git-30-380.html

Actions #4

Updated by wespipes69 over 12 years ago

Ok, everything checks out just fine on that build (fyi the x64 version will crash unless you copy over that sdl 1.3.dll).

So long as that branch gets integrated into the master eventually, this issue can be closed.

Actions #5

Updated by parlane over 12 years ago

Can we get save fixes merged then guys?

Actions #6

Updated by wespipes69 over 12 years ago

For what its worth, I have been using the latest build of this for awhile (general use with frequent save states) and everything has been running fine.

Actions #7

Updated by gabrielmorano over 12 years ago

soooo... when is the savestate fix be integrated into the main revs?
cuz for me it helps testing other things
and it's really complicated having to do 6 or 7 savestates in order to be lucky and get 1 to work (most just leads me into a freeze)

By the way... what wespipe has said it's not real for everyone, i been using the latest ones as well and saving in games like The Last Story or even Need for Speed The Run gets you a wrong savestate 85% of the time

Actions #8

Updated by rdragoon over 12 years ago

gabriel, i've been regularly compiling the latest builds with the save state fixes merged in. If you want it, you can get the latest (up 3.0-589 of the master build) at

64 bit - http://www.mediafire.com/?2rhlro7gyh61mcd
32 bit - http://www.mediafire.com/?7styt06epkyepit

I wouldn't expect it to get merged to master any time soon, unless the team decides to merge it against Nitsuja's wishes.

Actions #9

Updated by wespipes69 over 12 years ago

@gabrielm
What do you mean what I said wasn't real? Depends on the game, settings, etc. Some are pretty stable in master, some aren't. Haven't had any REGRESSIONS is my main point with my previous testing on this branch. States might not be perfect here, but so far it is better.

@rdrag
Awesome! I will use these from now until the branch gets merged(hopefully sooner than later). Where can I find future builds with the save fix branch?

Actions #10

Updated by rdragoon over 12 years ago

@wespipe I post new builds to http://tasvideos.org/forum/viewtopic.php?t=7692&start=600 every 1-2 weeks or so. Or whenever someone requests a particular revision.

Actions #11

Updated by skidau over 12 years ago

  • Status changed from New to Fixed

Fixed by r9ea8d543431b.

Actions

Also available in: Atom PDF