Project

General

Profile

Actions

Emulator Issues #5283

closed

Twilight Princess - Flames not showing correctly on torches

Added by greatbrian2 about 12 years ago.

Status:
Fixed
Priority:
Normal
Assignee:
-
Category:
GFX
% Done:

0%

Operating system:
N/A
Issue type:
Bug
Milestone:
Regression:
No
Relates to usability:
No
Relates to performance:
No
Easy:
No
Relates to maintainability:
No
Regression start:
Fixed in:

Description

  1. Game Name and ID (as it appears in right click > properties: "GZ2P01",
    "RSBE01", etc):

The Legend of Zelda: Twilight Princess (Wii), RZDE01

2) What is the expected output? What do you see instead?

A bright flame is expected. But I see a dim blob. This can be seen in some areas, such as the town near the castle (nighttime), kakariko village, and the arbiter's ground (blue flames show as faint blob).

3) Did the game ever work correctly (i.e. not have this problem) on an
earlier version of dolphin? Please specify the exact revision when the
problem began.

No. I believe this problem was not noticed by anyone.

4) What steps will reproduce the problem?
N/A. Occurs in every revision.

5) What version of dolphin are you using (32bit/64bit along with the
version as it appears in the title bar, etc)? Do not say 'latest version'
this changes multiple times a day.
On what operating system, drivers, and hardware? Be sure to list OS,
graphics driver information, and video card model if you are having
graphics problems, for example.

r7719, 32-bit, but I have used 3.0-432, 32-bit and the same problem occured.

Windows 7, 32-bit
Sapphire HD 6970 (It is not a driver/graphics settings problem from the card, as I noticed other Dolphin users have also the same problem based on their YT videos)

6) Please provide any additional information below.

EFB copy to RAM did not solve the problem. DX9 and DX11 didn't change anything. Basically, I toggled with every setting and to no avail.

7) Attachments. IMPORTANT! We have a limited storage quota on
GoogleCode, so please use a 3rd party host for screenshots or any other
files (http://min.us/ for example).

Dolphin version: http://min.us/mbpVmozwgo#1o
Wii Version: http://min.us/mXLOTRz0G#1o

Actions #1

Updated by LikesAndDislikesShow about 12 years ago

I noticed it as well and came here to see if anyone else noticed it. Anyone trying to figure out a solution?

Actions #2

Updated by Autoran1 about 12 years ago

Confirm this issue on new revisions
i've tried on old rev 6300
and evrything seems to be normal
http://i.imgur.com/LHF5g.jpg
Ok, i'll find the source of the problem

Actions #3

Updated by Autoran1 about 12 years ago

Rev 7386- r068855bbd cause this

Actions #4

Updated by Autoran1 about 12 years ago

There are lots of changes, i can't find which one cause the problem

Actions #5

Updated by parlane about 12 years ago

A setting has been changed then ? Maybe forced incorrectly to something else.

Actions #6

Updated by Autoran1 about 12 years ago

I think so too, never saw that setting commit did such thing, but this is exactly this one

Actions #8

Updated by NeoBrainX about 12 years ago

r068855bbd has been reverted some hundred revisions after its commit date. If it would've caused any issues, they wouldn't show up in recent revs.

Actions #9

Updated by Autoran1 about 12 years ago

NeoBrainX, please can you say the revision when it was reverted, cause i really believe that r068855bbd it's just activates an issue which is somewhere else

Actions #10

Updated by NeoBrainX about 12 years ago

ra779b92a09dccfb411a1bee84b078c7b2877379a

Actions #11

Updated by NeoBrainX about 12 years ago

btw, don't get confused by the commit message... I remember putting a typo there. Not quite sure which range actually is affected, but your commit is within that range for sure.

Actions #12

Updated by Autoran1 about 12 years ago

Thanks i'll test it

Actions #13

Updated by Autoran1 about 12 years ago

So if 7484 and issue still here, it means it's somewhere between 7386-7484
100 revs not too much

Actions #14

Updated by Autoran1 over 11 years ago

I was sick and so lazy last month, but i've compared r 7386 and 7484, and reverted some code that wasn't reverted by 7484, and it actually worked, will find that issue in a few hours

Actions #15

Updated by Autoran1 over 11 years ago

Ok, here's the problem:
These blue flame torches didn't work even before 7386 on DX11 and OGL
DX9 renders them correctly but only if Force Bi/Trilinear Filtering is On
and the problem was just in one line
i don't know how to fix it for DX11 or OGL but here's the DX9 solution

Actions #16

Updated by dan.sverin over 11 years ago

Personally i added
[Video_Enhancements]
ForceFiltering = 1

to my gameconfig file sins force filter causes glitches in some other games. Also i compiled with the dx9 patch posted so the torches works fine now.

Actions #17

Updated by Billiard26 over 11 years ago

  • Issue type set to Bug
  • Category set to gfx
Actions #18

Updated by Autoran1 over 10 years ago

Made some tests and found out that on older builds, no matter what Api are you using these torches could be fixed by manually turning off than back on Safe Texture Cache
It worked before "Turning OFF" STC was removed

Actions #19

Updated by tommyhl2.SS over 10 years ago

Does anyone have an NTSC memory card save near there?

Actions #20

Updated by Autoran1 over 10 years ago

PAL only, try to use GameFaqs save

Actions #21

Updated by Autoran1 over 10 years ago

Until r6288 rcf05cca7a69a these flames on torches were STC dependable, starting with it they've became ForceFiltering dependable but only for DX9, other plugins just dont' show em, and starting with ree3d6d66d77d of mipmap_fixes branch DX9 also doesn't show them like other plugins, but there is a good news too, starting with the same ree3d6d66d77d fixes UseRGBAtextures+ForceFiltering case for DX9, see the screen
http://i.minus.com/ib1S5oeA44aEdB.png
This is no longer an issue

Actions #22

Updated by milinha26.gsm over 10 years ago

That is not true, those flames won't show no matter what version i try playing the game, 3.0, 3.5 or 4.0, and i simply dont know enough of programming to be able to patch a source version with that patch that supposedly fixes the missing fire. Also no matter what graphic's settings combination i try those fires wont show. A good place to test this is that kakariko village and those torches inside the houses there, all you can see is the light effects but no fire textures. Is there a version of this emulator that works and that i could download here? thank you for your time and your attention.

Actions #23

Updated by NeoBrainX over 10 years ago

Reported to be fixed in tev_fixes_new.

Actions #24

Updated by NeoBrainX about 10 years ago

  • Status changed from New to Fixed

Fixed in commit a9a8c730748b (tev_fixes_new).

Actions

Also available in: Atom PDF