Project

General

Profile

Actions
Copy link

Emulator Issues #6548

closed

Check for GLEW version when building via CMake

Added by NeoBrainX over 10 years ago.

Status:
Fixed
Priority:
Normal
Assignee:
glennricster
% Done:

0%

Operating system:
N/A
Issue type:
Bug
Milestone:
Current
Regression:
No
Relates to usability:
No
Relates to performance:
No
Easy:
No
Relates to maintainability:
No
Regression start:
Fixed in:

Description

Dolphin requires GLEW 1.9 these days, but we don't check if this version is installed. Build fails at some point when trying to compile Dolphin with GLEW 1.8.

We should add a CMakeTests to check if GLEW>=1.9 is installed and use the one in Externals instead if it's not.

Actions
Copy link
 #3

Updated by delroth over 10 years ago

Cc-ing Glenn in case he wants to do more CMake changes :)

Actions
Copy link
 #4

Updated by glennricster over 10 years ago

Yeah, I saw this one. I will take a look at it.

Actions
Copy link
 #5

Updated by glennricster over 10 years ago

  • Status changed from New to Fixed

This issue was closed by revision 508888c93520.

Actions
Copy link
 #6

Updated by delroth over 10 years ago

  • Status changed from Fixed to Work started

Reopening: pkg_search_module(GLEW REQUIRED glew>=1.8) <-- this should not be REQUIRED, otherwise we never fallback to Externals.

Actions
Copy link
 #7

Updated by glennricster over 10 years ago

Thanks for pointing that out. That is clearly a mistake.

Actions
Copy link
 #8

Updated by t.ribke over 10 years ago

just commented out
pkg_search_module(GLEW REQUIRED glew>=1.8)
in CMakeTests/FindGLEW.cmake
works fine under ubuntu 12.04LTS

Actions
Copy link
 #9

Updated by glennricster over 10 years ago

t.ribke: It works for what?

Actions
Copy link
 #10

Updated by delroth over 10 years ago

  • Status changed from Work started to Fixed
Actions
Copy link

Also available in: Atom PDF