Project

General

Profile

Actions

Emulator Issues #7439

closed

Software renderer glitchy artifacts near bright regions with XFB emulation enabled

Added by jimmyli1528 almost 10 years ago.

Status:
Fixed
Priority:
Normal
Assignee:
% Done:

0%

Operating system:
N/A
Issue type:
Bug
Milestone:
Current
Regression:
Yes
Relates to usability:
No
Relates to performance:
No
Easy:
No
Relates to maintainability:
No
Regression start:
Fixed in:

Description

Game Name?
Super Mario Sunshine, Super Smash Bros Brawl, etc.

Game ID?
GMSE01, RSBE01

What's the problem? Describe what went wrong in few words.
When using software renderer with XFB emulation enabled, white areas, possibly bright areas, possibly areas with at least one full-scale channel, have glitchy color artifacts.

What did you expect to happen instead?
No glitchy artifacts with XFB enabled

What steps will reproduce the problem?

  1. Start any game
  2. Load any scene with bright areas
  3. In Brawl, the glitches can be seen as soon as the game boots in the Wiimote safety screen

Dolphin 3.5 and 3.5-367 are old versions of Dolphin that have
known issues and bugs, so don't report issues about them and test the
latest Dolphin version first.
Which versions of Dolphin did you test on?
4.0-1983, 4.0-1759 (8fc83d8ffca75f86c144a7798ebf0661a1eb68ef) (std min max)

Does using an older version of Dolphin solve your issue? If yes, which
versions of Dolphin used to work?
4.0-1757 is not broken. The bug began with 8fc83d8ffca75f86c144a7798ebf0661a1eb68ef Remove the min/max functions in CommonFuncs. (PR #334 from lioncash)

What are your PC specifications? (including, but not limited to: Operating
System, CPU and GPU)
Windows 7 x64, i5 3570K @3.8 GHz, Nvidia Asus GTX 660

Are you using the 32 or the 64 bit version of Dolphin?
x64

Is there any other relevant information? (e.g. logs, screenshots,
configuration files)
Mario Sunshine (ignore the unrelated water glitch): https://forums.dolphin-emu.org/attachment.php?aid=11625 or https://forums.dolphin-emu.org/attachment.php?aid=11626
SSBB Wiimote https://forums.dolphin-emu.org/attachment.php?aid=11627

Actions #1

Updated by phire almost 10 years ago

  • Status changed from New to Accepted

I suspect that "(u8)min(x, y)" doesn't mean the same as "std::min(x, y)"

I'll fix this tonight when I'm fixing the other software renderer bug.

Actions #2

Updated by phire almost 10 years ago

  • Status changed from Accepted to Work started
  • Regression set to Yes
Actions #3

Updated by phire almost 10 years ago

  • Milestone set to Current
Actions #4

Updated by phire almost 10 years ago

  • Status changed from Work started to Fixed

Merged to Master.

Actions

Also available in: Atom PDF