Project

General

Profile

Actions

Emulator Issues #8373

closed

Restructure how Dolphin saves newly created ActionReplay codes

Added by flacs about 9 years ago. Updated over 5 years ago.

Status:
Fixed
Priority:
Low
Assignee:
-
Category:
UI
% Done:

0%

Operating system:
N/A
Issue type:
Bug
Milestone:
Regression:
No
Relates to usability:
No
Relates to performance:
No
Easy:
No
Relates to maintainability:
Yes
Regression start:
Fixed in:

Description

Currently, we're creating a hidden, unrelated dialog and then call its save method which happens to do what we want. It works, but it's hacky and has bitten us in the butt before (issue 7060).

https://github.com/dolphin-emu/dolphin/blob/4a41ab17155e4103ea7844b6e6aa3c434dbb7e63/Source/Core/DolphinWX/Cheats/CreateCodeDialog.cpp#L91

Actions #1

Updated by JosJuice over 8 years ago

  • Status changed from New to Accepted

It has bitten us in the butt several times (issue 8950).

Actions #2

Updated by JosJuice over 5 years ago

  • Status changed from Accepted to Fixed

wx is dead!

Actions

Also available in: Atom PDF