Project

General

Profile

Actions

Emulator Issues #9275

closed

[OS X] @2x does not work for Flags and Platform Icons

Added by MayImilae over 8 years ago. Updated over 8 years ago.

Status:
Fixed
Priority:
Normal
Assignee:
-
% Done:

0%

Operating system:
OS X
Issue type:
Bug
Milestone:
Current
Regression:
No
Relates to usability:
No
Relates to performance:
No
Easy:
Yes
Relates to maintainability:
No
Regression start:
Fixed in:

Description

Since 4.0-8591 and the removal of the xpm icons, Dolphin has had the assets required to display the flags and platform icons in @2x when in HiDPI mode. But um, it's not working! See the attached image. While the toolbar icons are in retina, the Wii and GC icons and the flags are quite pixelated. Hopefully, something is just forgotten somewhere and it will be an easy fix.

Marking as Accepted, since this is a confirmation report from something JosJuice asked me to test.

Tested on:
MacBook Pro 13in 2012
OS X El Capitan 10.11
Core i5-3210M @ 2.5ghz
Intel HD Graphics 4000
Dell U2515H External Display (set to HiDPI via "DisplayResolutionEnabled -bool true")


Files

Screen Shot 2016-01-19 at 5.42.44 AM (1).png (150 KB) Screen Shot 2016-01-19 at 5.42.44 AM (1).png Dolphin in HiDPI on OS X MayImilae, 01/19/2016 12:01 PM
Actions #2

Updated by JosJuice over 8 years ago

Flags and platform icons being low-res makes sense, because the image loading code simply doesn't load @2x assets for those, but I didn't know that Wii banners also were low-res. Can you check if Wii banners are like that in earlier builds too? In particular, it might be affected by 4.0-8263.

Actions #3

Updated by JosJuice over 8 years ago

Please test if the flags and platform icons work properly here: https://github.com/dolphin-emu/dolphin/pull/3533

This PR also affects some other resources like the ones used in the filesystem view of game properties, but those don't have any @2x PNG files at the moment, so you shouldn't be able to notice any difference.

Actions #4

Updated by JosJuice over 8 years ago

  • Status changed from Accepted to Fix pending
Actions #5

Updated by JosJuice over 8 years ago

  • Status changed from Fix pending to Fixed
Actions

Also available in: Atom PDF