Project

General

Profile

Actions

Emulator Issues #9560

closed

[Android] images thumbnail not saves after closing emulation in recent builds

Added by brujo55 over 8 years ago. Updated about 8 years ago.

Status:
Fixed
Priority:
Normal
Assignee:
-
% Done:

0%

Operating system:
Android
Issue type:
Bug
Milestone:
Regression:
No
Relates to usability:
No
Relates to performance:
No
Easy:
No
Relates to maintainability:
No
Regression start:
4.0-9362
Fixed in:
5.0-1146

Description

description:
images thumbnail not saves after closing emulation in recent builds

last working build 4.0-9356

broken but no build available

4.0-9362 [Android] Reduce code redundancy and catch a leak (PR #3849 from Tsunamical)

so i tested 4.0-9364 Qt VS build no longer adds all of Data to Binary (PR #3842 from rukai)

this happend since

Actions #1

Updated by brujo55 over 8 years ago

just hit the refresh button on top and all images disapear

Actions #2

Updated by Anonymous over 8 years ago

brujo55 wrote:

just hit the refresh button on top and all images disapear

https://github.com/dolphin-emu/dolphin/pull/3855

Actions #3

Updated by JosJuice over 8 years ago

  • Status changed from New to Fix pending
  • Operating system Android added
  • Operating system deleted (N/A)

Thanks to both of you for reporting and fixing the problem this quickly. Hopefully the PR can get merged soon.

Actions #4

Updated by JosJuice over 8 years ago

  • Status changed from Fix pending to Fixed
Actions #5

Updated by brujo55 over 8 years ago

JosJuice wrote:

Thanks to both of you for reporting and fixing the problem this quickly. Hopefully the PR can get merged soon.

just tried 4.0-9377 and still the same. thanks

Actions #6

Updated by JosJuice over 8 years ago

  • Status changed from Fixed to New

I can't test this on my own, so I'll just re-open the issue for now.

Actions #7

Updated by brujo55 over 8 years ago

thanks sir.

Actions #8

Updated by Anonymous over 8 years ago

brujo55 wrote:

JosJuice wrote:

Thanks to both of you for reporting and fixing the problem this quickly. Hopefully the PR can get merged soon.

just tried 4.0-9377 and still the same. thanks

I'm not sure if you have the ability to build but I don't atm, but if you or someone else can do the following changes mentioned https://github.com/dolphin-emu/dolphin/pull/3855 individually and build apks for them, that would help. The last PR should still have fixed a double slash in the path, so it shouldn't be reverted.

Actions #9

Updated by Anonymous over 8 years ago

Actually I can submit a new PR and work off the web version of GH at the moment and then ping someone to get buildbot to do a build.

Actions #10

Updated by Anonymous over 8 years ago

brujo55 wrote:

thanks sir.

Can you tell me if this apk fixes it completely?: http://dl.dolphin-emu.org/prs/pr-3856-dolphin-latest.apk

Actions #11

Updated by brujo55 over 8 years ago

Tsunamical wrote:

brujo55 wrote:

thanks sir.

Can you tell me if this apk fixes it completely?: http://dl.dolphin-emu.org/prs/pr-3856-dolphin-latest.apk

OK, if I reinstall an older version before the problem appear then reinstall the latest build, all images thumb appear again and still work good until I hit the refresh button.

So the problem is relating to the refresh button function. ( cache not refreshing correctly)

Actions #12

Updated by kagutsuchi over 8 years ago

I believe this is the broken commit:

https://github.com/dolphin-emu/dolphin/commit/a0b54f558e3cc75c36c0d6f79947b324be71c555#diff-4a464af2063fe52def8bcf42dd5bc449

I'm still getting acquainted with Dolphin, so apologies if I misspeak. It looks to me like native paths use a hardcoded /sdcard/ path, whereas the above commit now uses Environment.getExternalStorageDirectory(), and these two paths might not always match. I'm guessing that once the game database is updated with the new Environment path (which is likely triggered by refreshing), the thumbnails will break.

While reverting the above commit should fix this issue (NOTE: I have not tested this yet), it might be better in the long run to set the native Android paths to use either Environment.getExternalStorageDirectory() (or Environment.getExternalStoragePublicDirectory(Environment.DIRECTORY_PICTURES)). Since these are static methods, it should be relatively straightforward to call from JNI.

Actions #13

Updated by JosJuice about 8 years ago

  • Status changed from New to Fixed
  • Regression start set to 4.0-9362
  • Fixed in set to 5.0-1146
Actions

Also available in: Atom PDF