Emulator Issues #9560
closed[Android] images thumbnail not saves after closing emulation in recent builds
0%
Description
description:
images thumbnail not saves after closing emulation in recent builds
last working build 4.0-9356
broken but no build available
4.0-9362 [Android] Reduce code redundancy and catch a leak (PR #3849 from Tsunamical)
so i tested 4.0-9364 Qt VS build no longer adds all of Data to Binary (PR #3842 from rukai)
this happend since
Updated by brujo55 over 8 years ago
just hit the refresh button on top and all images disapear
Updated by Anonymous over 8 years ago
brujo55 wrote:
just hit the refresh button on top and all images disapear
Updated by JosJuice over 8 years ago
- Status changed from New to Fix pending
- Operating system Android added
- Operating system deleted (
N/A)
Thanks to both of you for reporting and fixing the problem this quickly. Hopefully the PR can get merged soon.
Updated by JosJuice over 8 years ago
- Status changed from Fix pending to Fixed
Well, that was fast! Fixed by 4.0-9377. https://dolphin-emu.org/download/dev/63d2e6ca36e149feea990c22db11035a3e3a345f/
Updated by brujo55 over 8 years ago
JosJuice wrote:
Thanks to both of you for reporting and fixing the problem this quickly. Hopefully the PR can get merged soon.
just tried 4.0-9377 and still the same. thanks
Updated by JosJuice over 8 years ago
- Status changed from Fixed to New
I can't test this on my own, so I'll just re-open the issue for now.
Updated by Anonymous over 8 years ago
brujo55 wrote:
JosJuice wrote:
Thanks to both of you for reporting and fixing the problem this quickly. Hopefully the PR can get merged soon.
just tried 4.0-9377 and still the same. thanks
I'm not sure if you have the ability to build but I don't atm, but if you or someone else can do the following changes mentioned https://github.com/dolphin-emu/dolphin/pull/3855 individually and build apks for them, that would help. The last PR should still have fixed a double slash in the path, so it shouldn't be reverted.
Updated by Anonymous over 8 years ago
Actually I can submit a new PR and work off the web version of GH at the moment and then ping someone to get buildbot to do a build.
Updated by Anonymous over 8 years ago
brujo55 wrote:
thanks sir.
Can you tell me if this apk fixes it completely?: http://dl.dolphin-emu.org/prs/pr-3856-dolphin-latest.apk
Updated by brujo55 over 8 years ago
Tsunamical wrote:
brujo55 wrote:
thanks sir.
Can you tell me if this apk fixes it completely?: http://dl.dolphin-emu.org/prs/pr-3856-dolphin-latest.apk
OK, if I reinstall an older version before the problem appear then reinstall the latest build, all images thumb appear again and still work good until I hit the refresh button.
So the problem is relating to the refresh button function. ( cache not refreshing correctly)
Updated by kagutsuchi over 8 years ago
I believe this is the broken commit:
I'm still getting acquainted with Dolphin, so apologies if I misspeak. It looks to me like native paths use a hardcoded /sdcard/
path, whereas the above commit now uses Environment.getExternalStorageDirectory()
, and these two paths might not always match. I'm guessing that once the game database is updated with the new Environment
path (which is likely triggered by refreshing), the thumbnails will break.
While reverting the above commit should fix this issue (NOTE: I have not tested this yet), it might be better in the long run to set the native Android paths to use either Environment.getExternalStorageDirectory()
(or Environment.getExternalStoragePublicDirectory(Environment.DIRECTORY_PICTURES)
). Since these are static methods, it should be relatively straightforward to call from JNI.
Updated by JosJuice about 8 years ago
- Status changed from New to Fixed
- Regression start set to 4.0-9362
- Fixed in set to 5.0-1146
Should be fixed by 5.0-1146 (https://dolphin-emu.org/download/dev/3fe5e6dbce453df6c7ed37da80056bc6d47c7e06/)