Emulator

just hit the refresh button on top and all images disapear

brujo55 wrote:

just hit the refresh button on top and all images disapear

https://github.com/dolphin-emu/dolphin/pull/3855

JosJuice wrote:

Thanks to both of you for reporting and fixing the problem this quickly. Hopefully the PR can get merged soon.

just tried 4.0-9377 and still the same. thanks

thanks sir.

brujo55 wrote:

JosJuice wrote:

Thanks to both of you for reporting and fixing the problem this quickly. Hopefully the PR can get merged soon.

just tried 4.0-9377 and still the same. thanks

I'm not sure if you have the ability to build but I don't atm, but if you or someone else can do the following changes mentioned https://github.com/dolphin-emu/dolphin/pull/3855 individually and build apks for them, that would help. The last PR should still have fixed a double slash in the path, so it shouldn't be reverted.

Actually I can submit a new PR and work off the web version of GH at the moment and then ping someone to get buildbot to do a build.

brujo55 wrote:

thanks sir.

Can you tell me if this apk fixes it completely?: http://dl.dolphin-emu.org/prs/pr-3856-dolphin-latest.apk

Tsunamical wrote:

brujo55 wrote:

thanks sir.

Can you tell me if this apk fixes it completely?: http://dl.dolphin-emu.org/prs/pr-3856-dolphin-latest.apk

OK, if I reinstall an older version before the problem appear then reinstall the latest build, all images thumb appear again and still work good until I hit the refresh button.

So the problem is relating to the refresh button function. ( cache not refreshing correctly)

I believe this is the broken commit:

https://github.com/dolphin-emu/dolphin/commit/a0b54f558e3cc75c36c0d6f79947b324be71c555#diff-4a464af2063fe52def8bcf42dd5bc449

I'm still getting acquainted with Dolphin, so apologies if I misspeak. It looks to me like native paths use a hardcoded /sdcard/ path, whereas the above commit now uses Environment.getExternalStorageDirectory(), and these two paths might not always match. I'm guessing that once the game database is updated with the new Environment path (which is likely triggered by refreshing), the thumbnails will break.

While reverting the above commit should fix this issue (NOTE: I have not tested this yet), it might be better in the long run to set the native Android paths to use either Environment.getExternalStorageDirectory() (or Environment.getExternalStoragePublicDirectory(Environment.DIRECTORY_PICTURES)). Since these are static methods, it should be relatively straightforward to call from JNI.