Emulator Issues #11393
closedSoftware Renderer crashes immediately upon boot in Rogue Leader.
0%
Description
Game Name?
Star Wars - Rogue Squadron II - Rogue Leader
Game ID? (right click the game in the game list, properties, info tab)
GSWE64, GSWD64
MD5 Hash? (right click the game in the game list, properties, info tab, MD5 Hash: Compute)
0bf391bee90da09d6042016d23e7a9b1, fe32765ce6fcbb67ffd9e6f63d09cae0
What's the problem? Describe what went wrong.
Dolphin crashes immediately when running the game in Software Renderer.
What steps will reproduce the problem?
Boot the game with Software Renderer.
Is there anything else that can help developers narrow down the issue? (e.g. logs, screenshots,
configuration files, savefiles, savestates)
Source of the crash is in SW::CopyRegion due to an out-of-bounds memory access for the destination
vector. The passed dest_rect
(from EfbInterface::EncodeXFB()
) has a nonzero top
, but there is only enough memory allocated to hold a vertical bottom - top
(ie, height) elements.
I figured the correct solution would be to just have destination_x = j; destination_y = i;
instead of destination_x = j + dstrect.left; destination_y = i + dstrect.top;
, and that does indeed prevent the out of bounds access, but the resulting image doesn't look quite right with that. So have a bug report instead.
Updated by JMC4789 over 3 years ago
- Status changed from New to Accepted
I mean, our software renderer doesn't get much love but this is valid.
Updated by pokechu22 about 3 years ago
Should be fixed now that https://github.com/dolphin-emu/dolphin/pull/9321 is merged (5.0-14034).
Updated by pokechu22 about 3 years ago
- Status changed from Accepted to Fixed
- Fixed in set to 5.0-14034