Project

General

Profile

Actions

Emulator Issues #11753

closed

DTM replays made with GC adapter don't play back correctly

Added by SuperDavid almost 5 years ago. Updated almost 5 years ago.

Status:
Fixed
Priority:
Normal
Assignee:
-
% Done:

0%

Operating system:
N/A
Issue type:
Bug
Milestone:
Current
Regression:
Yes
Relates to usability:
No
Relates to performance:
No
Easy:
No
Relates to maintainability:
No
Regression start:
5.0-10202
Fixed in:
5.0-10479

Description

Game Name?

Mario Kart Double Dash and Super Smash Bros. Melee

Game ID? (right click the game in the game list, Properties, Info tab)

GM4E01 and GALE01

What's the problem? Describe what went wrong.

When I make a replay using the Gamecube adapter, it doesn't play back correctly.

What steps will reproduce the problem?

Start a game of Double Dash with controller port 1 set to Gamecube adapter for Wii U with the other ports turned off. Do a lap on a GP, and then play back the input, which should desync well before the first lap is finished. In Smash Bros. Melee, it would desync while I changed the difficulty level and life count before even starting classic mode. I didn't have any problems with replays made using a standard controller instead of the GC adapter.

Is the issue present in the latest development version? For future reference, please also write down the version number of the latest development version.

It's present in 5.0-10413.

Is the issue present in the latest stable version?

Not in 5.0

If the issue isn't present in the latest stable version, which is the first broken version? (You can find the first broken version by bisecting. Windows users can use the tool https://forums.dolphin-emu.org/Thread-green-notice-development-thread-unofficial-dolphin-bisection-tool-for-finding-broken-builds and anyone who is building Dolphin on their own can use git bisect.)

This first shows up in 5.0-10202, while it's not a problem in 5.0-10200.

I have attached a sample replay for Double Dash that I made with the GC adapter on 5.0-10202. The replay ends at the end of the first lap in a GP. Note that although I can't play it back correctly on the version I recorded it with, this will play back correctly on 5.0-10200, assuming buttons aren't pressed on the controller during playback, because 5.0-10200 allows input during playback, unlike 5.0-10202 which fixed that issue. The replay won't work even on 5.0-10200 if port 1 isn't set to Gamecube adapter before starting the replay.


Files

Double Dash replay 5.0-10202.dtm (102 KB) Double Dash replay 5.0-10202.dtm Cheats and memory cards are turned off. Enable MMU and sync GPU thread is also turned off. Deterministic dual core is set to fake-completion SuperDavid, 06/03/2019 11:06 PM
ddashtest 5.0-10413.dtm (96.6 KB) ddashtest 5.0-10413.dtm SuperDavid, 06/03/2019 11:42 PM
Actions #1

Updated by Techjar almost 5 years ago

I'm not able to reproduce this.

Actions #2

Updated by SuperDavid almost 5 years ago

Does the replay I uploaded work for you? I made a new folder with portable.txt and tried again with 5.0-10202, which can't play it back correctly, but it worked with 5.0-10200.

Actions #3

Updated by Techjar almost 5 years ago

No, I just created and played an input recording myself, as per your steps to reproduce. It didn't desync, so there must be some issue on your end.

Actions #4

Updated by SuperDavid almost 5 years ago

Does the following replay work? I created a new folder of 5.0-10413 with portable.txt and only turned off the Wii remote, switched port 1 to GC adapter, set my path and turned off the memory card. Everything else, I left at default. Note that although I couldn't get this replay to work on 5.0-10413, it did work on 5.0-10200.

Actions #5

Updated by JMC4789 almost 5 years ago

There is a weird bug associated with GameCube Adapters for Wii U if no controllers are plugged in and haven't been plugged in since Dolphin start... maybe that's the issue?

Actions #6

Updated by SuperDavid almost 5 years ago

This is the first time I heard of that bug, but I don't think that's the problem. With the replay "ddashtest 5.0-10413.dtm", I just discovered that it won't play back correctly on 5.0-10200 if the controller in port 1 is unplugged from the adapter, but that still doesn't change that I can get the replay working (if the controller is plugged in) on 5.0-10200 but can't get it working no matter what on 5.0-10413, the version I recorded it with.

Actions #7

Updated by SuperDavid almost 5 years ago

Actually, I'll need to more carefully compare it, but when I play it on 5.0-10200 with the controller unplugged, it seems to play back the same way as it does on 5.0-10413 with the controller plugged in. I'll compare them both side by side to be sure.

Actions #8

Updated by SuperDavid almost 5 years ago

Playing back the replay on 5.0-10200 with the controller unplugged from the adapter is an exact match with playing it back on 5.0-10413 with the controller plugged in. However, controllers plugged or unplugged, I have not been able to make any replay of Double Dash with the GC adapter on 5.0-10413 that doesn't desync.

Actions #9

Updated by Techjar almost 5 years ago

Okay, I'm able to reproduce this only if I make an input recording from boot. It does not happen if I start recording after booting game. It must have something to do with GC adapter initialization.

Actions #10

Updated by SuperDavid almost 5 years ago

Sorry, I always record from boot. I forgot to make a note of that.

Actions #12

Updated by SuperDavid almost 5 years ago

Great, thanks.

Actions #13

Updated by JosJuice almost 5 years ago

  • Status changed from New to Fix pending
  • Milestone set to Current
  • Regression changed from No to Yes
  • Regression start set to 5.0-10202
Actions #14

Updated by JMC4789 almost 5 years ago

...did the fix for this ever get merged?

Actions #15

Updated by JosJuice almost 5 years ago

  • Status changed from Fix pending to Fixed
  • Fixed in set to 5.0-10479

It did.

Actions

Also available in: Atom PDF