Emulator

Can you check 5.0-14993 (which fixed a regression from 5.0-14988)?

Additionally, does this issue only affect the DSP LLE recompiler, or does it also affect the DSP LLE interpreter?

5.0-14993 only fixed no audio caused by 5.0-14988. Performance problem still remains.

Only DSP LLE Recompiler is affected, and only when using dumped DSP's. The included reversed engineered ones are unaffected.

DSP LLE Interpreter has the same performance both before build 5.0-14988 and after.

Both FPS and VPS dip below full speed, if that's what you mean.

I've narrowed it down to commit 105d886

Reverting that one commit restores performance.

Huh. Commit 105d886 is a performance-accuracy trade off (disabling an optimization that was incorrect in some cases, though I don't remember whether it affected games or only some of the specialized tests I wrote). I can look into restoring that optimisation.

Just to clarify a bit more: did this cause the recompiler's performance to be worse than the interpreter? It'd be helpful if you could get performance values for the recompiler and interpreter both with and without the change and both with and without the dumped DSP ROMs, that'd be nice (but that is 8 combinations so it might be a bit annoying).

Recompiler is still faster than interpreter, though not by much on master.

Performance between each is as follows (bare with me if this is too unorganized):

Master with dumped DSP - recompiler: 26 FPS 50 VPS

Master with included DSP - recompiler: 37 FPS 75 VPS

Reverted commit with dumped DSP - recompiler: 36 FPS 75 VPS

Reverted commit with included DSP - recompiler: 44 FPS 90 VPS

Interpreter maintained roughly 20 FPS and 40 VPS in all examples with both builds.

Just for comparisons sake, though probably unnecessary, HLE for both builds is: 115 FPS 233 VPS.

I should note that while getting these performance numbers, I decided to check out some other games as well.
Most of them on Master maintained a FPS of over 70 and a VPS over 140 using the lle recompiler with dumped dsp's.
I'm not sure why Skies of Arcadia Legends is hit so much harder than the rest.

I recently updated my CPU to an Intel i9-14900K and using the above build I'm now getting 75 FPS and 150 VPS with dumped DSP's using LLE Recompiler.

I decided to try the latest dev build, but was surprised to see the framerate was only 40 FPS and 80 VPS .

I started bisecting and found that build 5.0-19886 is the first build to hit performance again.

This build only seems to add dark themes to windows, so I have no idea what could have affected performance with it.