Project

General

Profile

Actions

Emulator Issues #3429

closed

Super Mario Sunshine - intensity of red flashing not displayed correctly

Added by WMRPoker about 14 years ago.

Status:
Fixed
Priority:
Normal
Assignee:
-
Category:
GFX
% Done:

0%

Operating system:
N/A
Issue type:
Bug
Milestone:
Regression:
No
Relates to usability:
No
Relates to performance:
No
Easy:
No
Relates to maintainability:
No
Regression start:
Fixed in:

Description

I have to repost the issues, as it seems that j4ck.fr0st has blindclosed 3408, none of the bugs were fixed though, not even the red flahsing glitch!
I will now split the 3 defects of issue 3408 into 3 separate reports.

What steps will reproduce the problem?

  1. Start Dolphin, choosing any graphics plugin
  2. Start Super Mario Sunshine

What is the expected output? What do you see instead?
Enemies, at least "bosses" like the first goo plant for example should flash red when hit by water, and they actually did up to rev 4714, but dont do so anymore.

Dolphin version with the problem? Other Dolphin version without the
problem?
Played with the latest build (6320), red flahing bug didnt appear on nosound97's SMS youtube video. He used rev 4006.

32-bit or 64-bit and any other build parameters?
I only use the 64-bit version of Dolphin.

OS version and versions of tools/libraries used?
I run Windows 7 64-bit.

Please provide any additional information below.
PC specs:
Intel Core 2 Quad Q6600 2,4 Ghz
ATI Radeon HD5770, 1GB
4 GB RAM @ 800 Mhz
Win 7 64-bit

Actions #1

Updated by NeoBrainX about 14 years ago

You know, there's no need to repost issues... we can reopen them as well :P

Actions #2

Updated by WMRPoker about 14 years ago

Just want to help :p

Actions #3

Updated by florian98.rg about 14 years ago

are you sure ?
the red flashing is fixed.
just make sure you don't have "Disable Fog" ticked.

Actions #4

Updated by WMRPoker about 14 years ago

OK, i tested again and am superconfused - i swear i tested this morning, but couldnt see it flashing AT ALL - might be that i accidentally opened an older rev. It works, even though i think it needs a bit more adjustment, as the original "flashing intensity" appears to be sporadic (hope that sentence makes sense). Sometimes the flashing is very weak and hard to see. Can someone confirm that or am i halucinating?

Also, found out now, that SSAA is causing the EFB scaled copy glitch. Ill post that in the related issue report as well.

Well done so far Neo, sorry to j4ck.fr0st!

Actions #5

Updated by NeoBrainX about 14 years ago

florian98.rg: Disabling fog is not a fix, it's a workaround.

WMRPoker: Yeah, I know what you mean. I noticed that as well, which was why I didn't expect my commit to actually fix this issue.

Actions #6

Updated by florian98.rg about 14 years ago

i meant if you tick disable fog the effects are missing.
because of that you have to untick it.

Actions #7

Updated by NeoBrainX about 14 years ago

oh yeah, sorry... I just looked over your post very quickly and didn't spot the "don't" .. :D

Actions #8

Updated by BhaaL about 14 years ago

May I close this issue then, WMRPoker? :)

Actions #9

Updated by WMRPoker about 14 years ago

You may... hehe! Now, that Neo is aware of the fact, that some adjustments MIGHT have to be made in order to get the ultimate flashing experience! ;)

Actions #10

Updated by NeoBrainX about 14 years ago

Uh if it's still not perfect we should keep the issue open.
I'm bad at intentionally fixing things, I just look over the Dolphin source and occasionally spot random mistakes :P

Actions #11

Updated by BhaaL about 14 years ago

Someone might want to rename it then; since the flashing itself is there.

Actions #12

Updated by WMRPoker about 14 years ago

I would, but dont know how to afterwards.

Actions #14

Updated by skidau about 14 years ago

  • Category set to gfx
Actions #15

Updated by gnick79 almost 14 years ago

Re-bump!

Please, let's check for r6463 or above :)
This time red flashing should be ≡100% accurate (like the original)

Actions #16

Updated by gnick79 almost 14 years ago

  • Status changed from New to Fixed
Actions

Also available in: Atom PDF