Emulator

Just tried FPS for limiting on/off - as per below, same deal.

http://forums.dolphin-emulator.com/showthread.php?tid=15117&highlight=frame+skip

Although r7128 changed the frameskip logic, it would only take effect when you are "Starting recording" or "Play recording". Please determine the exact revision when this issue started occurring.

OK got it working in R7125, just going rev-by-rev to see where it got broke...

It's inbetween 7135 and 7140, just narrowing down now...

Well the website above I'm using to pull the Mac builds misses out 7136-7137, so I can't test those.

Suffice to say, it frame skipping works in 7135, but is broken in 7138.
Hope that's enough to find out what's caused it.

Issue still present on R7184

As of R7202 I've tried every option in Graphics plugin on/off and a load of different combinations (though not every single possibility clearly), and same deal - frame skipping causes video output to freeze.

Same issue here: As soon as frame skipping is enabled in Mac OS Lion, the video freezes, but the game runs faster in the background

Issue 4770 has been merged into this issue.

when is this going to be fixed cos it's been going on for a wile so I am stuck to using old versions of dolphin instead to new ones which are better.

I would like to also confirm this is not only Mac specific, on Ubuntu (10.04), frameskip stops video rendering, but the rest of the game works.

This issue has been going on for nearly a year please could the dolphin team fix it. There are a lat of mac uses and most of us are stuck with old versions or having to play the game really slowly because they don't have a high end mac. So please could someone fix this issue.

is this problem has been fixed recently ?

I experience the same issue.
OSX 10.6.8
Dolphin 3.0 368
macbook pro intel core duo 2.16 2Go RAM

When switching to frame skipping > 9 speed is 100% but frozen on a still frame.
Switching to 1 to 9 same issue with lower speed.

It would be so nice to fix this ;)

Regards

What does (No comment was entered for this change.) mean??

Means I changed the issue details, but did not make a comment. "Labels: OpSys-Linux" showed what I did.

Still happening on 3.0-421, Lion, Macbook Air Core i7 (Intel HD3000 graphics).

I had this issue on Debian 64-bit until I built with libav support.

I think this bug was introduced in r7135. A change was made in that revision:

--- a/Source/Plugins/Plugin_VideoOGL/Src/Render.cpp
+++ b/Source/Plugins/Plugin_VideoOGL/Src/Render.cpp
@@ -964,11 +966,11 @@ void Renderer::Swap(u32 xfbAddr, FieldType field, u32 fbWidth, u32 fbHeight,cons
if (g_bSkipCurrentFrame || (!XFBWrited && (!g_ActiveConfig.bUseXFB || !g_ActiveConfig.bUseRealXFB)) || !fbWidth || !fbHeight)
{
if (g_ActiveConfig.bDumpFrames && data)
#ifdef _WIN32
AVIDump::AddFrame((char *) data);

•    #else
  

•    #elif defined HAVE_LIBAV
         AVIDump::AddFrame(data);
     #endif
     Core::Callback_VideoCopiedToXFB(false);
     return;
  

  }

See what happens if neither _WIN32 nor HAVE_LIBAV is defined:

if (g_ActiveConfig.bDumpFrames && data)
Core::Callback_VideoCopiedToXFB(false);

Probably not what the author intended. I edited this file (Source/Plugins/Plugin_VideoOGL/Src/Render.cpp) and just added braces:

if (g_ActiveConfig.bDumpFrames && data)
{
#ifdef _WIN32
AVIDump::AddFrame((char *) data);
#elif defined HAVE_LIBAV
AVIDump::AddFrame(data, w, h);
#endif
}
Core::Callback_VideoCopiedToXFB(false);

There are two places in this file where it needs to be done. After recompiling, I no longer get this bug.

Nice find! Adding braces should indeed fix that issue. I'll commit that change with author name "plbl4ster plbl4ster@gmail.com", is that ok with you?

Yes, that's fine with me.

Woohoo! Only took a year or two, but congrats on the awesome find! Thank
you!!

On Tuesday, August 28, 2012, wrote: