Project

General

Profile

Actions

Emulator Issues #4813

closed

Inhibit Screensaver Pull request

Added by Sonicadvance1 over 12 years ago.

Status:
Fixed
Priority:
Normal
Assignee:
Category:
UI
% Done:

0%

Operating system:
N/A
Issue type:
Bug
Milestone:
Regression:
No
Relates to usability:
No
Relates to performance:
No
Easy:
No
Relates to maintainability:
No
Regression start:
Fixed in:

Description

Name of clone:
InhibitScreensaver branch

Purpose of code changes on this branch:
Allows the user to control the ability to inhibit screensaver via INI file.
A combination of Nvidia hardware/drivers and displayport connection causes unwanted flickering issues in Linux when disabling screensaver.

When reviewing my code changes, please focus on:
Everything, isn't very big.

After the review, please pull into branch:
master

Actions #1

Updated by Billiard26 over 12 years ago

Those ini entries probably shouldn't be added on Windows, or someone should implement the inhibit screensaver option for Windows.

Actions #2

Updated by Sonicadvance1 over 12 years ago

In Frame.cpp in function MSWWindowProc we are disabling screensaver there for Windows.
There is also some code in EmuWindow.cpp for disabling screensaver as well I can only assume that that is for when drawing to main isn't enabled?
Would be trivial to add to Windows as well if needed.

Actions #3

Updated by Anonymous over 12 years ago

currently the variable seems to be named inversely to how it's used.
Also, I'm not sure that the API we're calling is even the correct one. Perhaps some other call does not have this bug with nv+DP (like XScreenSaverSuspend). Dunno...

Actions #4

Updated by glennricster over 12 years ago

XScreenSaverSuspend only works if you are using the XScreenSaver to activate screensavers. Most desktop managers do not use that anymore. KDE and Gnome both have their own screensaver management programs. The point of the xdg-screensaver script is that it provides a way to manage screensavers for all linux screensaver managers. There isn't another alternative that even attempts for this at this point.

Actions #6

Updated by parlane over 11 years ago

  • Status changed from New to Fixed
Actions

Also available in: Atom PDF