Emulator Issues #5472
closed
Legend of Zelda: Wind Waker/Twilight Princess: EFB to RAM + Scaled EFB Copy does not produce properly-scaled EFB copies for higher resolutions
0%
Description
These two Zelda games have EFB effects that function similarly, but differ in appearance. In Wind Waker it manifests as a depth-of-field effect that covers everything that's over a certain distance from the camera, intensifying depending on the distance, while in Twilight Princess it controls the (ridiculous) bloom effects.
Terrible-explanation-of-stuff-you-guys-already-know aside, these effects currently do not scale correctly on resolutions higher than GameCube native res when using Scaled EFB Copy and EFB to RAM without cache.
Wind Waker (GZLE01):
EFB to RAM without cache: http://cl.ly/HLVj
EFB to RAM with cache/EFB to Texture: http://cl.ly/HLJc
(Look at the tree leaves.)
Twilight Princess (GZ2E01):
EFB to RAM without cache: http://cl.ly/HKwC
EFB to RAM with cache/EFB to Texture: http://cl.ly/HL8r
(Look at the jail cell's bars.)
(Yes, yes, I'm using widescreen hack and I'm running at a screen resolution that's not a multiple of GameCube native res, but it appears without widescreen hack and on those resolutions too.)
This bug doesn't appear at all under the Hashless branch, which doesn't have a cache option for EFB to RAM.
(Intel HD Graphics 3000, Intel Core i5-2557M 1.7 GHz.)
(Dolphin 3.0-692, Dolphin [Hashless] 3.0-699, OS X 10.7.4.)
Updated by pauldacheez almost 13 years ago
Ooh! I found another one of these bugs.
LostWinds: Winter of the Melodias (a game that EFB effects are vital to, since they cover the whole screen) suffers from a similar EFB to RAM + Cache bug, though it appears at native res as well as any other res.
EFB to RAM without cache: http://cl.ly/HLiR
EFB to RAM with cache: http://cl.ly/HLRz
EFB to Texture, just for good measure: http://cl.ly/HLi8
(Look at the blurred background.)
Again, this doesn't appear on Hashless with EFB to RAM. (EFB to Texture's appearance on Hashless is identical to master.)
(Also on Hashless, once you're ingame you can enable EFB to RAM temporarily, then switch to EFB to Texture for a graphical-glitch-free view. Impossible on master, though.)
Updated by NeoBrainX almost 13 years ago
Please post your full video settings. If you're using one of the "auto" IRs, does the issue appear for e.g. 2x or 3x as well?
Updated by pauldacheez almost 13 years ago
These issues appear on any internal resolution higher than 1x Native, as I've said. Here's it at 2x: http://cl.ly/HMdP
In terms of settings, I'm using OpenGL, and the only options that aren't disabled or set to default are the EFB options (EFB to RAM, Scaled EFB Copy) and texcache accuracy (set to Safe - I just like it that way). Here's my gfx_opengl.ini: http://pastebin.com/pXG67HjT
Updated by
Updated by hatarumoroboshi almost 13 years ago
This problem happens in Wii Sports (tennis) as well, but in this case the hashless branch doesn't fix it.
Updated by hatarumoroboshi almost 13 years ago
Revision 1495d36a372b of the hashless branch now fixes the Wii Sports (tennis) problem that I mentioned.
Updated by NeoBrainX almost 13 years ago
- Status changed from Accepted to Fixed
This issue was closed by revision 48c402d72b3c.
Updated by NeoBrainX almost 13 years ago
Thanks for creating a proper bug report :>
branch will be merged to master soonish.
Updated by NeoBrainX almost 13 years ago
This issue was closed by revision cc0523e55be8.
Updated by pauldacheez almost 13 years ago
You're welcome, NeoBrain. <3
Is this awesome new branch just a temporary fix that'll be completely replaced by Hashless when it's merged in? Since, y'know, it's texcache/EFB stuff, and Hashless is all about that.
Updated by NeoBrainX almost 13 years ago
Once Hashless gets merged most of these patches will be obsolete, but I wanted to have that stuff fixed anyway. Plus, I don't want to have ppl get misconceptions about Hashless - afaict it's not really supposed to fix anything, apart from the ugly mess that the EFB RAM copy cache has become.
Updated by pauldacheez almost 13 years ago
Ah, ah, very good points. Hashless is gonna take a while to finish, so it does make sense to fix it now.