Project

General

Profile

Actions
Copy link

Emulator Issues #7473

closed

Frame dumping broken in software renderer

Added by NeoBrainX almost 10 years ago.

Status:
Fixed
Priority:
High
Assignee:
-
% Done:

0%

Operating system:
N/A
Issue type:
Bug
Milestone:
Current
Regression:
Yes
Relates to usability:
No
Relates to performance:
No
Easy:
No
Relates to maintainability:
No
Regression start:
Fixed in:

Description

Broken by https://github.com/dolphin-emu/dolphin/commit/d52e241cdf331761aa26d965b223b837a8bd6a8e because DebugUtil::OnFrameEnd is not being called anymore since that commit.

This is somewhat critical because we'd like to have the software renderer support frame dumping for fifoci.

@phire: What's the specific reason the call to OnFrameEnd was removed there? Was it a simple oversight or something specific?

Actions
Copy link
 #1

Updated by phire almost 10 years ago

It was removed because the with adding xfb support the final frame was no longer ready at this point.

Should be called on swap after the xfb is copied back out of gamecube ram instead, but looks like that got missed.

Actions
Copy link
 #2

Updated by NeoBrainX almost 10 years ago

Well, can you submit a fix for it? :)

Actions
Copy link
 #3

Updated by phire almost 10 years ago

Sure, I'll do it tonight.

Actions
Copy link
 #4

Updated by phire almost 10 years ago

  • Status changed from New to Work started
Actions
Copy link
 #5

Updated by phire almost 10 years ago

  • Status changed from Work started to Fixed

Merged to master.

Actions
Copy link

Also available in: Atom PDF