Actions
Emulator Issues #7473
closedFrame dumping broken in software renderer
Status:
Fixed
Priority:
High
Assignee:
-
% Done:
0%
Operating system:
N/A
Issue type:
Bug
Milestone:
Current
Regression:
Yes
Relates to usability:
No
Relates to performance:
No
Easy:
No
Relates to maintainability:
No
Regression start:
Fixed in:
Description
Broken by https://github.com/dolphin-emu/dolphin/commit/d52e241cdf331761aa26d965b223b837a8bd6a8e because DebugUtil::OnFrameEnd is not being called anymore since that commit.
This is somewhat critical because we'd like to have the software renderer support frame dumping for fifoci.
@phire: What's the specific reason the call to OnFrameEnd was removed there? Was it a simple oversight or something specific?
Updated by phire almost 10 years ago
It was removed because the with adding xfb support the final frame was no longer ready at this point.
Should be called on swap after the xfb is copied back out of gamecube ram instead, but looks like that got missed.
Updated by phire almost 10 years ago
- Status changed from New to Work started
See Pull request #622
https://github.com/dolphin-emu/dolphin/pull/622
Actions