Project

General

Profile

Actions

Emulator Issues #8264

closed

Online functionality broken since 4.0-5450 (Nintendo WFC or Wiimmfi)

Added by keller.g over 9 years ago.

Status:
Fixed
Priority:
Normal
Assignee:
-
% Done:

0%

Operating system:
N/A
Issue type:
Bug
Milestone:
Regression:
No
Relates to usability:
No
Relates to performance:
No
Easy:
No
Relates to maintainability:
No
Regression start:
Fixed in:

Description

Game Name?
Mario Kart Wii (Unmodified)
Mario Kart Wii (Wiimmfi)
Super Smash Bros Brawl (Unmodified)
Super Smash Bros Brawl (Project M)
Likely others

Game ID?
Mario Kart Wii - RMCP01
Super Smash Bros Brawl - RSBE01
Super Smash Bros Brawl (Project M) - RSBEC3

What's the problem? Describe what went wrong in few words.
In 4.0-5445 and earlier, any attempt to connect to Nintendo WFC on unmodified games fails with a "cannot connect" error (expected). Attempting to connect to Wiimmfi with a modified Mario Kart Wii or Project M game results in a successful connection.

As of 4.0-5450, doing any of the above results in the following in a "Warning" dialog that stalls emulation and appears to be infinitely repeating.

"Invalid Read from 0x10fd90XX, PC = 0x80004374"

What steps will reproduce the problem?
[Don't assume we have ever played the game and know any level names. Be as
specific as possible.]

  1. Start any of the mentioned games (unmodified or Wiimmfi modified)
  2. Attempt to connect to online play
  3. Observe the warnings

Dolphin 3.5 and 3.5-367 are old versions of Dolphin that have
known issues and bugs, so don't report issues about them and test the
latest Dolphin version first.
Which versions of Dolphin did you test on?
4.0-5445 - works
4.0-5450 - broken

What are your PC specifications? (including, but not limited to: Operating
System, CPU and GPU)
Windows 7 x64
Intel i5 4690K running at 4.5 GHz
AMD Radeon R9 200 Series

Actions #1

Updated by magumagu9 over 9 years ago

Looks like this is an existing bug that was uncovered by my changes to address translation; 0x10fd909f definitely isn't a valid address in this context. I'd appreciate help tracking down the issue.

Actions #2

Updated by magumagu9 over 9 years ago

  • Status changed from New to Accepted
Actions #3

Updated by magumagu9 over 9 years ago

  • Status changed from Accepted to Fix pending
Actions #4

Updated by keller.g over 9 years ago

I would love to test, but I can't figure out how to download the build you just initiated. The closest I can get is here:

https://buildbot.dolphin-emu.org/builders/pr-win-x64/builds/1366

How do I actually download what was built to test?

Sorry for being a newb. =P

Actions #6

Updated by keller.g over 9 years ago

PR 1366 solves the issue, thanks for the quick response!

Actions #7

Updated by tueidj over 9 years ago

The fix doesn't look correct to me; IOS is meant to return offsets (not physical nor virtual pointers), conversion to effective addresses should be handled correctly by the PowerPC.

Actions #8

Updated by skidau over 9 years ago

  • Status changed from Fix pending to Fixed
Actions #9

Updated by tueidj over 9 years ago

Welcome to Dolphin, where we don't give a shit if code is right - just as long as it hides the real problems.

Actions

Also available in: Atom PDF