Emulator Issues #9884
closed
Country is default even if you change it in the wii menu
0%
Description
What's the problem? Describe what went wrong.
After updating to the newest revision, the country is the default; switzerland and changing it with the wii menu does not work.
What steps will reproduce the problem?
- Go to Wii menu settings; country
- Change country
- Close Wii menu
- Open Wii menu
- The country has not been changed
Which versions of Dolphin did you test on? Does using an older version of Dolphin solve your issue? If yes, which versions of Dolphin used to work?
5.0-1296 Worked on 5.0
What are your PC specifications? (CPU, GPU, Operating System, more)
CPU: i5-6600k
GPU: gtx 570
OS: Windows 7
Is there any other relevant information? (e.g. logs, screenshots,
configuration files)
Updated by JosJuice over 8 years ago
Are you sure this worked on 5.0? I can't recall it working any better in the past than it does now.
Updated by leoetlino over 8 years ago
Reproduced in 5.0-1296. As soon as emulation is stopped, the country setting is reset. Note: Switzerland was not selected, as there is no red border around it.
Switzerland not being selected seemed suspicious, so it turns out we overwrite the country setting depending on the Wii language setting (see here). If your language is set to English, your country will always be overwritten with 49, which is the country code for the USA.
Previously Dolphin only did this when the language is changed in the config dialog (c881262); PR 4319 made this happen whenever emulation starts.
This behaviour is supposed to fix issue #4287, but it doesn't seem to be needed anymore (4.2J loads in Japanese even with the country code set to France), so I'll open a PR to remove this code.
Updated by leoetlino over 8 years ago
Fix pending: https://github.com/dolphin-emu/dolphin/pull/4446
Could you test PR 4446 and see if the issue is fixed?
Updated by leoetlino over 8 years ago
- Status changed from Fix pending to Fixed
- Fixed in set to 5.0-1798