Emulator Issues #10535: Vulkan Vertex Rounding broken by 5.0-5419 - Emulator - Dolphin bug tracker

Actions

Copy link

Emulator Issues #10535

closed

Vulkan Vertex Rounding broken by 5.0-5419

Added by Hyperniy over 6 years ago. Updated over 6 years ago.

Status:

Fixed

Priority:

Normal

Assignee:

% Done:

Operating system:

N/A

Issue type:

Bug

Milestone:

Regression:

Relates to usability:

Relates to performance:

Easy:

Relates to maintainability:

Regression start:

Fixed in:

5.0-5767

Description

Game Name?

Shadow The Hedgehog
Sonic Riders
Sonic 4
Sonic Adventure DX

Game ID? (right click the game in the game list, properties, info tab)

GUPP8P - ShTH
GXEE8P - SR
WSNP8P - Sonic 4
GXSE8P - SADX

MD5 Hash? (right click the game in the game list, properties, info tab, MD5 Hash: Compute)

b0f99d01f76f6cd8acadbec67ac02400 ShTH
SADX b5d979135826338fa0d90d40f907c9b2
SR 80155de587c0233e39ab545c2e771749
S4 56b47579f869472e6882b99bd9361f90

What's the problem? Describe what went wrong.

Enabling Vertex Rounding breaks HUD in some games, and totally breaks ShTH.
Sonic Heroes works perfect with Vertex Rounding.

What steps will reproduce the problem?

Disable Vertex Rounding

Is the issue present in the latest development version? For future reference, please also write down the version number of the latest development version.

Yes [5.0-5437]

If the issue isn't present in the latest stable version, which is the first broken version? (You can find the first broken version by bisecting. Windows users can use the tool https://forums.dolphin-emu.org/Thread-green-notice-development-thread-unofficial-dolphin-bisection-tool-for-finding-broken-builds and anyone who is building Dolphin on their own can use git bisect.)

5.0-5419

If your issue is a graphical issue, please attach screenshots and record a three frame fifolog of the issue if possible. Screenshots showing what it is supposed to look like from either console or older builds of Dolphin will help too. For more information on how to use the fifoplayer, please check here: https://wiki.dolphin-emu.org/index.php?title=FifoPlayer

[Attach any fifologs if possible, write a description of fifologs and screenshots here to assist people unfamiliar with the game.]

What are your PC specifications? (CPU, GPU, Operating System, more)

AMD FX-6300
Gigabyte GTX 750 2GB
Windows 7 Professional
8 GB DDR3

Is there anything else that can help developers narrow down the issue? (e.g. logs, screenshots,
configuration files, savefiles, savestates)

[Anything else here]

Files

Download all files

1.dff (4.19 MB) 1.dff	fifolog	Hyperniy, 09/09/2017 02:37 PM
GUPP8P-1.png (2.86 MB) GUPP8P-1.png	what a mess!	Hyperniy, 09/09/2017 02:38 PM
GXEE8P-3.png (3.11 MB) GXEE8P-3.png	VR disabled	Hyperniy, 09/09/2017 02:46 PM
GXEE8P-2.png (3.82 MB) GXEE8P-2.png	VR enabled	Hyperniy, 09/09/2017 02:46 PM
WSNP8P-2.png (2.65 MB) WSNP8P-2.png	No HUD mod!	Hyperniy, 09/09/2017 02:51 PM
WSNP8P-1.png (2.74 MB) WSNP8P-1.png	VR disabled 2	Hyperniy, 09/09/2017 02:51 PM
GXSE8P-2.png (121 KB) GXSE8P-2.png	???	Hyperniy, 09/09/2017 02:54 PM
GXSE8P-3.png (183 KB) GXSE8P-3.png	ok, ok	Hyperniy, 09/09/2017 02:54 PM
2.dff (3.39 MB) 2.dff	fifolog 2	Hyperniy, 09/09/2017 02:55 PM
pe.txt (807 Bytes) pe.txt	List of broken post-processing effects	Hyperniy, 09/16/2017 04:30 PM

Actions

Copy link

Updated by markwest76 over 6 years ago

Also notice that Vertex Rounding problems are somewhat related to real XFB problems: in every revision where Vertex Rounding is broken, real XFB is broken as well (Vulkan backend)

Actions

Copy link

Updated by Stenzek over 6 years ago

I am wondering if this is related to the realxfb issue (bug in NV's SPIR-V frontend, which bypassing with the GLSL extension just happened to "work around"). Vertex rounding seems to work fine with the attached fifologs on my system.

Actions

Copy link

Updated by markwest76 over 6 years ago

For sure it is related

Actions

Copy link

Updated by JMC4789 over 6 years ago

I literally have a GTX 760 and can't reproduce this... it's so frustrating. If someone on the team could reproduce this I'm sure we could figure out how to fix it.

Actions

Copy link

Updated by lmello over 6 years ago

I have a GTX 1060, dolphin-5495, linux 4.9.48, nvidia 375.82 (manjaro).

If I select Vertrex Rounding on Vulkan the video output is NULL

Actions

Copy link

Updated by Hyperniy over 6 years ago

Also, this is how it looks on emulator
https://www.youtube.com/watch?v=-tXXuBMI6HQ

Actions

Copy link

Updated by LuismaSP over 6 years ago

Hyperniy wrote:

Also, this is how it looks on emulator
https://www.youtube.com/watch?v=-tXXuBMI6HQ

Hi Hyperniy, with your permission i´m going to refer your video to my issue #10527 because the FXAA problem in the 1:36

Actions

Copy link

Updated by Hyperniy over 6 years ago

File pe.txt pe.txt added

Ok, I don`t prohibit.

Actions

Copy link

Updated by markwest76 over 6 years ago

Did someone report to Nvidia about the broken Driver?

Actions

Copy link

#10

Updated by FireNX70 over 6 years ago

markwest76 wrote:

Did someone report to Nvidia about the broken Driver?

Either someone did and NVidia ignored them or no one has reported that yet because this issue has been known for a couple of weeks.

Actions

Copy link

#11

Updated by Stenzek over 6 years ago

Tested on my GTX 1080 as well as the 780 now, and I still can't reproduce it. Tried combinations of vertex rounding/xfb/postprocessing, and all were fine. This was on Ubuntu 16.10 with nvidia-375, but I doubt distributions will change anything.

Not saying there isn't an issue, but I'm guessing it's somewhere in the driver or shader compiler. The latest NV dev driver has the GLSL extension "fixed" again, so we can re-enable it after that reaches the stable channel, and everything should be back to normal. Can't do much else for now.

Actions

Copy link

#12

Updated by markwest76 over 6 years ago

Well that's a great new, so let's wait for the fixed driver

Actions

Copy link

#13

Updated by LuismaSP over 6 years ago

Stenzek wrote:

Tested on my GTX 1080 as well as the 780 now, and I still can't reproduce it. Tried combinations of vertex rounding/xfb/postprocessing, and all were fine. This was on Ubuntu 16.10 with nvidia-375, but I doubt distributions will change anything.

Not saying there isn't an issue, but I'm guessing it's somewhere in the driver or shader compiler. The latest NV dev driver has the GLSL extension "fixed" again, so we can re-enable it after that reaches the stable channel, and everything should be back to normal. Can't do much else for now.

Nvidia released the latest driver (385.69) yesterday. Maybe is time to revert the changes of 5.0-5419 and test it with the new driver and see if fixes this issue and #10527

Actions

Copy link

#14

Updated by Stenzek over 6 years ago

LuismaSP wrote:

Stenzek wrote:

Tested on my GTX 1080 as well as the 780 now, and I still can't reproduce it. Tried combinations of vertex rounding/xfb/postprocessing, and all were fine. This was on Ubuntu 16.10 with nvidia-375, but I doubt distributions will change anything.

Not saying there isn't an issue, but I'm guessing it's somewhere in the driver or shader compiler. The latest NV dev driver has the GLSL extension "fixed" again, so we can re-enable it after that reaches the stable channel, and everything should be back to normal. Can't do much else for now.

Nvidia released the latest driver (385.69) yesterday. Maybe is time to revert the changes of 5.0-5419 and test it with the new driver and see if fixes this issue and #10527

Tried with 385.69 and no change. Can't say I'm surprised, given it's not a major release. Hopefully the next major release will include the Vulkan changes/fixes present in the dev driver.

Actions

Copy link

#15