Emulator Issues #12151
closed
Windows updater does not properly request administrator access
0%
Description
Currently, the updater does two undesirable things:
When Dolphin is installed in a protected folder (such as Program Files) the Updater does not ask for administrator privileges before attempting to run, and subsequently fails.
When the Updater fails, it fails silently, with no error or warning that the update did not succeed.
I propose that either the Updater ask for permission when in a protected folder, or at least inform the user to run Dolphin as administrator so that when it launches the updater, it also runs elevated, allowing it to succeed.
Updated by delroth over 4 years ago
We already do that though? For a very long time too. https://github.com/dolphin-emu/dolphin/blob/master/Source/Core/WinUpdater/Main.cpp#L76
You did not provide any information about which Dolphin version you're using.
Updated by superluig164 over 4 years ago
delroth wrote:
We already do that though? For a very long time too. https://github.com/dolphin-emu/dolphin/blob/master/Source/Core/WinUpdater/Main.cpp#L76
You did not provide any information about which Dolphin version you're using.
I'm using 5.0-12106. I've had Dolphin in Program files since 5.0 stable. Never once has it asked for administrator permission before launching the updater, instead failing to update silently. I must launch Dolphin with administrator privileges first, to allow it to create a child process which is allowed to modify the protected folder.
Updated by delroth over 4 years ago
- Subject changed from [Feature Request] Make the Updater request administrator permissions or issue a warning when required to Windows updater does not properly request administrator access
- Status changed from New to Accepted
- Operating system Windows added
- Operating system deleted (
N/A)
I just tested removing my permissions on my Dolphin folder and indeed we don't seem to be properly asking for administrator access. Haven't debugged why exactly, but we have code to try and do that, and it seems to not do what we expect.
Updated by superluig164 over 4 years ago
delroth wrote:
I just tested removing my permissions on my Dolphin folder and indeed we don't seem to be properly asking for administrator access. Haven't debugged why exactly, but we have code to try and do that, and it seems to not do what we expect.
Awesome, thanks. Can't wait to see this working properly!
Updated by JosJuice over 4 years ago
- Milestone set to Current
Setting as Current, since stable releases frequently are installed to Program Files.
Updated by Anonymous about 2 years ago
Please post more specifics about the failure. Maybe a procmon log would help.
If I install Dolphin to Program Files (e.g. using a Local Admin login, or running the installer elevated), and then execute Updater.exe from c:\Program Files\Dolphin as a user without Admin privs, I see the expected UAC popup asking for creds of an account with Admin privs. If I provide creds, I see a new Updater.exe be created elevated as expected.
At the moment this issue does not look valid to me.
Updated by Anonymous about 2 years ago
Hopefully fixed by https://github.com/dolphin-emu/dolphin/pull/11189
Updated by