Emulator

The problem with not using the game code is that Dolphin can't distinguish between the case where you have a dump of a disc that hasn't been added to the datfile yet and the case where you have a bad dump of a disc which is in the datfile. Because of this, I do not want to remove the game code matching logic. I suppose it would be possible to report "good dump" if the disc image matches an entry in the datfile even if the datfile is missing game codes, though... But it would not make the logic simpler, and I would still recommend everyone to use datfiles with game codes.

Game codes being missing from the datfile has nothing to do with GC vs Wii. If you download the datfile using the URL http://redump.org/datfile/wii/serial,version (requires you to be logged in to a Redump account with dumper status, as usual), you'll get the game codes.

That is true that you can't guarantee that the dump is bad (at least in the case there were no issues were detected), however matching by code isn't a foolproof guarantee either due to possible disc revisions with the same product code not being present.

In both cases, the chances of this happening for a normal user are ... slim, and people who specialize in rarities know damn well if their dumps are good or not.

Thanks for the link though, I always download whatever default dat file is provided in the download section, so I always forget you can customize it.

13xforever wrote:

That is true that you can't guarantee that the dump is bad (at least in the case there were no issues detected), however matching by code isn't a foolproof guarantee either due to possible disc revisions with the same product code not being present.

In both cases, the chances of this happening for a normal user are ... slim, and people who specialize in rarities know damn well if their dumps are good or not.

Thanks for the link though, I always download whatever default dat file is provided in the download section, so I always forget you can customize it.

Wait, now that I think about it... how did you manage to bypass the code path that shows the "Serial and/or version data is missing" panic alert and exits with "Failed to parse Redump.org data"? (I added that check in https://dolphin-emu.org/download/dev/0f4c971326ae9389b3ad55b0fefacb708d148f4d/.)

That is true that you can't guarantee that the dump is bad (at least in the case there were no issues were detected), however matching by code isn't a foolproof guarantee either due to possible disc revisions with the same product code not being present.

The code takes the revision into account as well. That is why you need to download http://redump.org/datfile/wii/serial,version and not just http://redump.org/datfile/wii/serial.

Thanks for the link though, I always download whatever default dat file is provided in the download section, so I always forget you can customize it.

To be fair, the ability to do that is entirely undocumented except for a random forum post made by iR0b0t a year or two ago.

See also https://github.com/dolphin-emu/dolphin/pull/8782