Emulator

We started using C++11 a long time ago, and Dolphin's build system is currently set to use C++17: https://github.com/dolphin-emu/dolphin/blob/66fc335c1198a05fe1df3e6b86f973fb31da96b7/Source/CMakeLists.txt#L25

But, if it worked before and it doesn't work now, I guess something is indeed wrong in Dolphin's source code or build system files.

Hi nkeck72,

Could you provide which distribution you are running?

Thank you

ssdsnake wrote:

Hi nkeck72,

Could you provide which distribution you are running?

Thank you

(I was able to build this about 12 hours ago from master, also on x86_64, so curious why it failed for you)

Note: I also compiled this using make -j16. Using single-threaded make, even from a fresh clone, doesn't solve the problem. Because the logs were captured from the -j16 run, it may be a bit difficult to read, so allow me to post the actual error message here.

[ 52%] Building CXX object Source/Core/Core/CMakeFiles/core.dir/NetPlayCommon.cpp.o
/home/noah/sources/dolphin/Source/Core/Core/NetPlayCommon.cpp: In function ‘bool NetPlay::DecompressPacketIntoFolderInternal(sf::Packet&, const string&)’:
/home/noah/sources/dolphin/Source/Core/Core/NetPlayCommon.cpp:238:14: error: ‘all_of’ is not a member of ‘std’
238 | if (std::all_of(name.begin(), name.end(), [](char c) { return c == '.'; }))
| ^~~~~~
make[2]: *** [Source/Core/Core/CMakeFiles/core.dir/build.make:3002: Source/Core/Core/CMakeFiles/core.dir/NetPlayCommon.cpp.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:1534: Source/Core/Core/CMakeFiles/core.dir/all] Error 2
make: *** [Makefile:156: all] Error 2

ssdsnake wrote:

Hi nkeck72,

Could you provide which distribution you are running?

Thank you

I am running Arch Linux, with all packages up to date as of 11AM this morning (12/15/21).

nkeck72 wrote:

ssdsnake wrote:

Hi nkeck72,

Could you provide which distribution you are running?

Thank you

I am running Arch Linux, with all packages up to date as of 11AM this morning (12/15/21).

ok, thanks. I'll spin up a VM tonight and see if I can reproduce it.

NtePlayCommon.cpp is probably missing an #include <algorithm>...

JosJuice wrote:

Yes, it does. Will fix.

Thanks. Not sure why I didn't check that :P

In any case, I will pull the PR's branch and see if that fixes it.

The build now works as expected. Thanks for the prompt response. :)