Emulator Issues #4046
closed
Changing the language from "Chinese (Traditional)" to any other language crashes Dolphin
Added by Nick.Lustig over 13 years ago.
Relates to performance:
No
Relates to maintainability:
No
Description
What's the problem ?
If you try to change the language from "Chinese (Traditional)"
to any other language, dolphin immediately crashes.
For example:
-
"Chinese (Simplified)" works without any problems.
The whole language list is translated.
http://www.abload.de/img/35hkv.png
-
However the language "Chinese (Traditional)"
has the problem mentioned above.
Also the language list isn´t properly translated.
http://www.abload.de/img/1qcn4.png
-
Dolphin crashes immediately while changing
the language from "Chinese (Traditional)"
to any other language.
http://www.abload.de/img/2dcid.png
Operating system and version ?
Windows Vista x64
Please provide any additional information below:
r6922 updated languages and changed something
wich has to do with strings.
I believe this rev messed something up.
The developer also tried to add "Traditional Chinese translations"
but forgot to commit the file.
With r6923 he added the missing file.
Now you can change to that language but you can´t change back
without getting a crash.
Tracing program crashes in [StringUtil.cpp->CharArrayFromFormatV->vsnprintf], should be vsnprintf UTF8 values can not be processed, problem-solving within the modified zh_TW.po value "您必須重新啟動 Dolphin 使更改生效。" to "", rebuild [Languages] project will be normal.
Can you post a full backtrace of the crash?
- Status changed from New to Accepted
The problem is based on the fact that MsgAlert translates the string, then passes it as .c_str() to CharArrayFromFormatV ... which makes no sense. I'm surprised this is the only place it crashes.
we really should make common/core unicode... :|
Nick: Your number 2 is not a bug in dolphin. It is just the fact that the translator of the traditional Chinese did not translate those strings. The translator for the simplified Chinese did translate those strings. Talk to the translators on the language thread in the forums about that.
godisgovernment: Why does that make no sense? This segmentation fault does not happen on linux, and doesn't happen for me on windows (last I tried) either.
Nick: I just looked at the end of your post.
"The developer also tried to add "Traditional Chinese translations"
but forgot to commit the file.
With r6923 he added the missing file."
What is your point about this? This isn't a problem. I forgot to add the file in one revision, and added it in the next. If you look back through dolphin's revision history you will see that just about every dolphin developer has forgotten to add a file to svn version control at on point or another. Stop belaboring this point.
Chill Glenn, I´m not belaboring anything.
The point is, this is the replacement for
"Dolphin version with the problem ?"
and "Rev that caused it".
So everyone knows which revisions have
something to do with it and the
history of the issue. Because
this issue isn´t like the others,
that something worked before
and then broke. So I can´t say
rxxxx broke it. There is no
offense... you´r acting like
I would have written:
"Glennricster tried to add "Traditional Chinese translations"
but was to stupid commit the file.
With r6923 he added the missing file
but the crappy code doesn´t work."
The only person who started to belabor this point, is you.
I´m sorry you felt attacked, next time I try to
write this less misunderstandable...
"Your number 2 is not a bug in dolphin."
" It is just the fact that..."
Ok, I talk to them when I´m bored ^^
I can't reproduce this crash using Mamario's Win32 build of r7477 on Windows 7 x86.
Was this issue fixed? Should it be closed?
The issue is not fixed. It is just worked around for now. The strings that were causing the problem are simply not translated. When this issue is fixed those strings will be able to be translated without causing segmentation faults.
- Issue type set to Bug
- Category set to ui
Is this issue present in recent revisions? (there were some possibly relevant changes)
If the issue still exists please state which revision was tested.
I just tested this and this issue is not fixed.
- Priority set to High
- Milestone set to Current
- Status changed from Accepted to Fixed
This issue was closed by revision 9ea01aa7a845.
Also available in: Atom
PDF