Project

General

Profile

Actions

Emulator Issues #6680

closed

Dolphin 4.0.1 fixes

Added by skidau over 10 years ago.

Status:
Fixed
Priority:
Normal
Assignee:
% Done:

0%

Operating system:
N/A
Issue type:
Task
Milestone:
Regression:
No
Relates to usability:
No
Relates to performance:
No
Easy:
No
Relates to maintainability:
No
Regression start:
Fixed in:

Description

Fixes for Dolphin 4.0.1 - for regressions from 3.5

tlbhack setting fix: r785171abb4cf7440b61ac9bc3fad739e93038a5e
SMB2 Music fix: r9a2c7df8dca3ed8e977dcc8df3d27216e5377981
PAL XFB shaking fix: r0696fc93b2df07f42f32df6545822bad095189bc
Single core crash fix: r6209067daa5121e383d173f7272bbf20bc108047

Actions #1

Updated by kostamarino over 10 years ago

r823bb44ba7cd8024bea554edd151c7383c78c2ee and re544894f14119317049c2a5b30b0beeb06731751
could also be added since those games where fixed before 4.0 and their gameinis needed an update.

Actions #2

Updated by delroth over 10 years ago

Planning to merge in all the gameini changes anyway, including the TLB Hack bug fix.

Comex, could you please list all the ABI/whatever related commits that I need to cherry-pick to have a working 4.0.1 on Win/Lin/Mac x86/x64 SC/DC?

Actions #3

Updated by delroth over 10 years ago

TODO for me: fix missing dxruntime stuff in the installer and make it non optional.

Actions #4

Updated by comexk over 10 years ago

23401b717ec95c17095f8f73dae44fd201c276ec + 2ca42e0497bab9719a05f43378aa7be4e5dfe2c1 should do it.

Actions #5

Updated by lpfaint99 over 10 years ago

the issue reported in this thread
https://forums.dolphin-emu.org/Thread-dolphin-4-0-refuses-to-read-or-create-memory-card-files?pid=295632#pid295632

should be fixed for 4.0.1
by something similar to either of the patches I have attached

Actions #6

Updated by lpfaint99 over 10 years ago

I should have made note that this bug has always been there, is has just not been typical that memory card paths collide with dolphin's path in just the wrong way
"some path"/dolphin emulator/...memcard.raw
"same path"/dolphin/dolphin.exe
the check does not include the directory separator and incorrectly changes the path to an almost certainly nonexistant path

Actions #7

Updated by delroth over 10 years ago

Woops, my bad, missed that with global-user-dir. Thanks.

I think 1. is probably the best - will keep relative paths with local user dir. Could you commit it to master, test it and give me the git hash on this issue so I can cherry-pick it in 4.0.1?

Actions #8

Updated by lpfaint99 over 10 years ago

Tested, and working revision r8c103a8deea777c3dbb65b805407846f5fe1252e

Actions #9

Updated by rachelbryk over 10 years ago

r99c89ae should be included too.

Actions #11

Updated by rachelbryk over 10 years ago

rcc05f66ba1a0 too.

Actions #12

Updated by rachelbryk over 10 years ago

The above two commits are critical. The first in particular fixes an issue where probably every wii game breaks for users with usernames containing non-ascii characters.

Actions #13

Updated by NeoBrainX over 10 years ago

  • Status changed from New to Fixed

4.0.1 released. Sorry for not considering the two patches rachelbryk.

Actions #14

Updated by vuohioksennus over 10 years ago

BTW, will there be 4.0.1 source tarball at "Downloads" page?

Actions #15

Updated by mbc07 over 10 years ago

Mac and Linux will have to compile by itself... Checkout "stable" branch, it have the same code used in 4.0.1

Actions #16

Updated by parlane over 10 years ago

specifically check out the tag 4.0.1

git checkout tags/4.0.1

But we will try to get the src up for download. Please note though that Google Code will stop supporting the Downloads page next year.

Actions

Also available in: Atom PDF