Emulator

Note The D3DX (D3DX 9, D3DX 10, and D3DX 11) utility library is deprecated for Windows 8 and is not supported for Windows Store apps.
Note Instead of using this function, we recommend that you use the DirectXTex library, CaptureTexture then SaveToXXXFile (where XXX is WIC, DDS, or TGA; WIC doesn't support DDS and TGA; D3DX 9 supported TGA as a common art source format for games). For the simplified scenario of creating a screen shot from a render target texture, we recommend that you use the DirectXTK library, SaveDDSTextureToFile or SaveWICTextureToFile.

And it should be noted that DXTK cannot be used due to license issues ( http://www.gnu.org/licenses/license-list.html#ms-pl ).

WIC can be regarded as a system library IMO since it's available by default since Vista. However, it's not available in Windows XP afaik. And we yet have not dropped XP support, have we?

we've dropped xp support for our d3d backend, is that enough?

I'm not sure how hard it is to load WIC dynamically.

But yes, I hadn't thought of that :p If we can load WIC dynamically it should be fine.

Uh, I thought I already committed a patch which unified the handling between D3D and OGL, using wx to save as OGL currently does. I've been out of town so I don't remember what happened to it (reverted? committed on a branch by mistake?), but there is no reason for the functionality of "save buffer to image file" to be renderer dependent.

comexk: Cf. revision 0b02880b7699b8049be0ae64ff1461a792a9bf9b .

That change consisted almost entirely of moving things around, and this change is worse. Why not fix it instead of reverting it?

(It's relatively hard for me to test D3D11, since it doesn't work in VMware, but when I have time I'll fix it and revert this.)

This issue was closed by revision 7cd536b61f61.