Actions
Emulator Issues #6947
closedDon't use GL_MAP_COHERENT_BIT in the buffer storage code path in OpenGL
Status:
Fixed
Priority:
Normal
Assignee:
-
% Done:
0%
Operating system:
N/A
Issue type:
Bug
Milestone:
Regression:
No
Relates to usability:
No
Relates to performance:
No
Easy:
No
Relates to maintainability:
No
Regression start:
Fixed in:
Description
What's the problem? Describe what went wrong in few words.
We are lazy and use GL_MAP_COHERENT when using the buffer storage code path
What did you expect to happen instead?
Explicitly use MemoryBarriers whenever required. This theoretically allows for higher performance. Testing showed that this is not the case for the (very limited) amount of test cases, but there's on the other hand no reason why we NEED GL_MAP_COHERENT. It might be more convenient, but since we know exactly when we need to synch, doing so explicitly does no harm either.
Actions