Emulator

Ping? Cc-ing RachelB since she might be interested in working on this.

Let me explain what's going on with this one.

When a client closes their window, we don't remove them from the pad mapping, and thus what happens is the rest of the clients hang waiting for NetPlay input that will never come.

While we should be more resilient towards a rogue client not sending us any input, since it could happen due to network failures (implementing a timeout after which we drop a client, for instance), a quick fix would be to send a LEAVE_GAME packet after when the client stops their game, and we'd remove them from the pad mapping.

There is a UI issue with this though -- if a client stops their emulation, they can't start it again afterwards (since we don't send savestates over), but they're still connected to the server. So if a client stops their emulation by accident, they're fucked.

Easy fix: Implement starting from savestate, amirite?

But, What happened before was that if a client closed their netplay window, it just stayed closed. The only time it crashed is if they disconnected from teh server while the game was still running. If we went back to that, at least it'd be something.

Why don't we just stop everyone if anyone with a pad mapped stops emulation?

IF that lets spectators leave, close out netplay entirely, I'm good with this change. Right now if a spectator leaves it usually freezes netplay (Maybe not since Jasper's pad changes?)

If ANY player could stop the netplay game, I think that's better than it crashing, or letting them leave at this point. Adding savestate support/continue/anything else can be a separate issue.

Yeah, sounds good to me. I tried to start this, but the flow that happens when stopping emulation is so convoluted that I gave up.

Eh? Can't we just do exactly what happens when the host stops emulation currently?

http://code.google.com/p/dolphin-emu/source/detail?r=cea7737aefa2afc6083a14f404c807dc2add894f&name=netplay-stop-fix

Works for me. Fixes the crash, stops netplay when anyone with a pad mapped stops emulation, and allows spectator hosts to stop emulation without anyone else being affected. Please test it.

This issue was closed by revision 3ff81c919922.