Emulator Issues #6845
closed
Improper Texture Loading in OpenGL
0%
Description
Game Name:
Xenoblade Chronicles NTSC version
Game ID?
XX4E01
What went wrong?
Using the OpenGL backend, some HD textures load improperly.
What did you expect to happen instead?
Not to get a italicized Landmark text which DX9 backend does properly.
What steps will reproduce the problem?
- Install the HD Textures pack
- Settings are EFB to RAM, Cache, Safe, Ignore Format, OpenMP, FDC, Load Custom Textures
- Start the game, load a save, open up fast travel (- button)
Which versions of Dolphin did you test on?
4.0.1
Which version of Dolphin used to work?
No idea
What are your PC specifications (example: Operating System, CPU and GPU)?
Win 7 x64, i7-2600k overclocked (4.7Ghz), HD 6800 latest drivers.
64 or 32 bit Operating System?
64
64 or 32 bit Dolphin?
64
Any other relevant information (e.g. logs, screenshots, configuration
files)
Image of bug:
http://www.mediafire.com/view/r3m59yh5o8gp8je/dolbr.png
Updated by degasus over 11 years ago
Can you may check which custom texture itself is broken? I guess it will be easier to check which one exactly is broken.
Updated by noian.xhh2a over 11 years ago
It's either e391690b_2 or 92287313_2 since those are the two copies of Landmark in the HD Textures pack. Again, DX9 backend loads it correctly. I'm not sure if there are other examples of improper loading in OpenGL elsewhere since I mainly use DX9 (was running OpenGL for comparisons purposes and saw it)
Updated by noian.xhh2a over 11 years ago
I noticed that OpenGL dumps in .tga format rather than .png ...I wonder if that is related the issue? (Different internal file format perhaps), all of the images are .png in the HD texture pack...I do have ignore format changes ticked. Other than that, I can't figure out which one it is exactly via dump to textures (does it not dump what is loaded?)
Updated by MayImilae over 11 years ago
That was changed in 4.0-379 (r3a13dfdd9b97). OpenGL dumps in PNG now.
Updated by noian.xhh2a over 11 years ago
I'll test with Dolphin 4.0.2 and see if it makes a difference.
Updated by degasus over 11 years ago
I guess this issue is because of the default value of GL_UNPACK_ALIGNMENT=4.
This won't matter as long as every custom image is either in 4 byte formats (rgba) or the width is a multiple of 4 pixels.
For performance, both should be true. As the real GPU only allows texture with multiple of 16 pixels, it should be fine to only allow integer upscale factors.
We could change this behavoir, but I'm more for add an ERROR_LOG for every strange custom texture.
Updated by degasus over 11 years ago
- Status changed from New to Questionable
If you want, just try to change this line to =1: https://code.google.com/p/dolphin-emu/source/browse/Source/Core/VideoBackends/OGL/Render.cpp#611
I've also added some checks in revision 01351795f01d as many texture packs use wrong texture sizes, just try the broken one and check the error log.
Updated by JMC4789 over 10 years ago
HD Textures should be working fine in OpenGL now. Can we get an update?
Updated by JMC4789 over 10 years ago
- Status changed from Questionable to Fixed
Assuming fixed after trying it myself