Project

General

Profile

Actions

Emulator Issues #8359

closed

Peach's Castle-Video Modes Bugs

Added by kolano about 9 years ago. Updated over 8 years ago.

Status:
Fixed
Priority:
Normal
Assignee:
-
% Done:

0%

Operating system:
N/A
Issue type:
Bug
Milestone:
Regression:
No
Relates to usability:
No
Relates to performance:
No
Easy:
No
Relates to maintainability:
No
Regression start:
Fixed in:

Description

Game Name?
Peach's Castle

Game ID?
00

What's the problem? Describe what went wrong in few words.
The pause menu allows for various video modes to be selected, some result in problems for Dolphin:

480ProgAa (i.e. 480p Progressive Anti-aliased): Results in the bottom half the image to flash between black and the expected image.

240Int (i.e. 240p Interlaced): Results in the image rendering squished in the top half the frame, and slid to the left.

240IntAa (i.e. 240p Interlaced Anti-aliased): Results in the image rendering squished in the top half the frame, and slid to the left.

What did you expect to happen instead?
Output to render as on GameCube.

What steps will reproduce the problem?
[Don't assume we have ever played the game and know any level names. Be as
specific as possible.]

  1. Press start to access the pause menu
  2. Move down to "RENDER MODE"
  3. Press right to select one of: 480ProgAa, 240Int, 240IntAa
  4. Observe rendering issues

Dolphin 3.5 and 3.5-367 are old versions of Dolphin that have
known issues and bugs, so don't report issues about them and test the
latest Dolphin version first.
Which versions of Dolphin did you test on?
4.0-5923

Does using an older version of Dolphin solve your issue? If yes, which
versions of Dolphin used to work?
Unknown

What are your PC specifications? (including, but not limited to: Operating
System, CPU and GPU)
Windows 7, Intel Core i7-960, nVidia GeForce 580

Is there any other relevant information? (e.g. logs, screenshots,
configuration files)
https://wiki.dolphin-emu.org/index.php?title=File:Peach%27s_Castle-480ProgAa.jpg
https://wiki.dolphin-emu.org/index.php?title=File:Peach%27s_Castle-240Int.jpg

Actions #1

Updated by JMC4789 about 9 years ago

  • Status changed from New to Accepted

Turning on RealXFB will fix some of the modes, but definitely not all of them.

Actions #2

Updated by kolano about 9 years ago

It doesn't fix any of the modes for me, and in fact seems to break additional modes.

With RealXFB:
480IntAa Shows only the top half the image twice
480ProgAA: Shows only the top half the image twice
240Int: Shows 1/4th tje image repeated horizontally 4 times /w interlacing messed up
240IntAa: Shows 1/4th tje image repeated horizontally 4 times /w interlacing messed up

Actions #3

Updated by phire about 9 years ago

Yeah, Dolphin simply doesn't implement those video modes, because almost every single game uses 480Int (which we then act like it's 480Prog)

Exceptions:

Dragon Ball Z Budokai 1 and 2 use either 240Int or 240IntAa mode, I haven't checked which. See #7332

Rogue Leader and Rebel Strike use 480IntAa, which dolphin downgrades to 480Int.

Actions #4

Updated by kolano about 9 years ago

OK, might we want to merge that issue here, since it provides a likely easier test for it's resolution?

Actions #5

Updated by phire about 9 years ago

I think we actually have 3 issues here.

  1. The xfb copies which Peach's Castle is using for AA mode are broken (RS2/RS3 are fine)
  2. AA modes don't actually do any AA (emulating 3 sample AA on modern graphics cards might be a bit hard)
  3. 240Int mode doesn't work.

Note: 480IntAa/480ProgAa aren't expected to work with real/virtual xfb disabled as they do multiple xfb copies per frame.

Actions #6

Updated by JMC4789 almost 9 years ago

All video modes are displaying for me in OpenGL with PR2686

https://github.com/dolphin-emu/dolphin/pull/2686

Actions #7

Updated by phire almost 9 years ago

With/without real/virtual xfb enabled?

Actions #8

Updated by JMC4789 over 8 years ago

  • Status changed from Accepted to Fix pending

Requires Virtual or RealXFB. All video modes confirmed working on either. They actually display as intended (we don't interleave interlaced, so the screen shakes, making it obvious it's working.) Hell, the quality even drops when you go to the 240 video modes; which is pretty amazing if you ask me.

Fixed in PR2686 -> https://github.com/dolphin-emu/dolphin/pull/2686

Actions #9

Updated by JosJuice over 8 years ago

  • Status changed from Fix pending to Fixed
Actions #10

Updated by kolano over 8 years ago

I'm still seeing the bottom half the screen flashing issue in 2 modes: 480ProgAa, 480IntAa.

Actions #11

Updated by JosJuice over 8 years ago

  • Status changed from Fixed to Accepted

I'll re-open this, then.

Actions #12

Updated by JMC4789 over 8 years ago

THIS IS THE ONE I WANTED TO MARK AS FIXED.

All hail booto for real.

Fixed in PR3252.

Ignore the DS being too wide, that's totally phire's fault.

Actions #13

Updated by JMC4789 over 8 years ago

  • Status changed from Accepted to Fixed

Fixed in 4.0-8340 -> https://dolphin-emu.org/download/dev/2ab0bad137957e3717046a7620b8229610978883/

There's a separate bug for DoubleStrike not working.

Actions

Also available in: Atom PDF