Project

General

Profile

Actions
Copy link

Emulator Issues #9006

closed

Fifo saving is broken

Added by tueidj over 8 years ago. Updated over 8 years ago.

Status:
Fixed
Priority:
Normal
Assignee:
delroth
% Done:

0%

Operating system:
N/A
Issue type:
Bug
Milestone:
Current
Regression:
Yes
Relates to usability:
No
Relates to performance:
No
Easy:
Yes
Relates to maintainability:
No
Regression start:
Fixed in:

Description

FifoDataFile::PadFile() is meant to be a very simple function that extends a file's size by writing nul bytes. Unfortunately it was apparently written by someone who doesn't comprehend how fwrite works.
Depending on how much padding is being written (varies depending on the number of frames/number of memory updates being written), three things can happen: no error, unhandled segfault, or (my personal favourite) a segfault that gets eaten and results in a fifo data file with a valid header/frame info list but messed up fifo data/memory contents.

Actions
Copy link

Also available in: Atom PDF