Emulator

meh

Yeah... I'm going to say you're testing this wrong, because this PR literally has no way of impacting code paths outside of WFS, AFAICT.

I redownloaded the following PRs and got the same results:
5.0-5291: SLOW
5.0-5264: FINE

Can someone try to reproduce the problem?

I followed your exact steps and performance is exactly the same, 120 - 140 fps on master, 120-140 fps on 5.0-5264

If you can, download visual studio, compile the build before/after WFS, and do the performance analysis, and show us the different hot paths. That'll tell us what is making it slower for you.

There's a guide on how to compile on the github page, and I'll try to provide any extra assistance I can.

Have you tried running them separately? It seems as though Windows schedules the selected app to get more performance considerations than background ones. In you screenshot, the old build is selected, meaning it would run significantly faster.

Oops, I forgot to mention that I photoshoped that image. Each build was run separately. I'm looking into performance profiling now.

And for both profiler output runs, I completed a one stock match mario vs mario on final destination then closed Dolphin.

Another thing you can do is bisect to commits inside of WFS merge if you're compiling yourself, which could be super useful!

Unfortunately the commits appear to be dependent upon each other. I tried reverting a few of them individually but each one would crash the emulator.

Fair enough, thank you for the attempt!

Checked your performance logs, the slowdown appears to be in the D3D Async compiler... can you try OpenGL/Vulkan?

I could reproduce the problem on DX11 and OGL. Could not reproduce on Vulkan.

It sounds like this is completely unrelated to WFS and more likely something going on with your computer not liking the new exes.

So, I relooked at your performance graph, the D3D thing had to do with ubershaders compiling. I have no idea why Vulkan isn't affected, that commit shouldn't cause a slowdown.

I had Ubershaders set to hybrid for all of the tests I have done for this issue. I set Ubershaders to Disabled and retested. It did not make a difference.

Like I said, it was just throwing it off, I filtered it and now they're mostly identical.

Can you put a breakpoint on File::CopyDir and see if it ever gets hit while you're playing.

For the reference, File::CopyDir is in Source/Core/Common/FileUtil.cpp.

Yes, the breakpoint has been set up correctly, and it has also been triggered. (Though it seems like it got triggered when you're starting Dolphin, and we're only interested in if it gets triggered when running the game.)

I needed to silence access violations to be able to use the debugger but that breakpoint was not triggered during gameplay.

Is your issue fixed if you replace this code in FileUtil.cpp line 571

    else
    {
      Rename(source, dest);
    }

with:

    else if (destructive)
    {
      Rename(source, dest);
    }

Oh wow that does fix it! (tested all video backends, re-enabled codes, and re-enabled hybrid Ubershaders)
Thanks!

(╯°□°）╯︵ ┻━┻