Emulator

These are unfortunately a result of MacOS not having a native style for QPushButtons with QSizePolicy::Expanding, and QToolButton in general. Not sure if there's any workaround for this.

See how this build affects the "Configure Input" window: https://dl.dolphin-emu.org/prs/pr-7279-dolphin-latest.dmg

Partially fixed in 5.0-8480

A few more have come up:

• Presets button in Game Config Editor tab of Properties
• Calibrate buttons in mapping window

Presets buttons have been fixed in 5.0-9701

The only solution for the calibrate buttons would be to make them a QPushButton with a menu, like the game config editor presets menu. This is not an acceptable solution though, as it makes them less intuitive to use, since we can only have a menu and not a default push action.

That's true, but I feel like the buttons being slightly less convenient to use is better than how they currently look. Of course, there's no reason to punish Linux and Windows users for a macOS limitation, so maybe they could be made into QPushButtons only on macOS.

If this were a much less-used window like somewhere in debugging, leaving the buttons as is would be just fine. But the GameCube/Wiimote mapping windows are very frequently visited – I know I use them at least once every time I play games on Dolphin.

The particular way we use QToolButton there isn't feasible to change without a complete redesign of it, unfortunately. It's not a simple matter of swapping out the button type. Various behaviors are dependent on that being a button with a default action.

Understandable, thanks for checking on it though.

Partially improved upon by https://github.com/dolphin-emu/dolphin/pull/8032