Emulator

This bug/issue was introduced somewhere past revision 4.0-5710. I have tried 2 different computers with AMD and Nvidia graphics cards and have seen the same effect. However, I should note that this only happens when using Direct 3D mode and not OpenGL. My specs are listed below.

Windows 8.1 x64
AMD Phenom II X4 980 3.70GHz
16GB RAM
Radeon HD 6970

Windows 8.1 x64
Intel i7-4790K 4.00GHz
8GB RAM
GeoForce GTX 970

That's interesting... I haven't tested using OpenGL before, because for some reason, every game performs about 30% worse on it (meaning that if the fps is 30 on Direct3d, it'll be about 22-20 fps on OpenGL), but on the latest revision (4.0-6114), D3D crashes and OGL don't. A shame, though, as it's reported that OGL is more developed than D3D. I've been playing some games on it to see if there were some improvements (at least on my setup), but it didn't have, so I'll keep using 4.0-6000, until I see the D3D/fullscreen exit issue is fixed. I should get a new computer though...

I seem to be affected by this bug as well. I use the Direct3D backend, and I play in exclusive fullscreen. I did some testing and found that this issue was introduced by 4.0-6021. This is a change to how parts of Dolphin do threading.

I went into the Core::Stop function in Core\Core\Core.cpp and commented the last two lines (which were introduced in the 6021 revision above):

if (s_emu_thread.joinable())
s_emu_thread.join();

and built Dolphin. I was able to close the emulation window with Escape. However, when I go to close the Dolphin GUI window itself, I get an error from the Visual C++ Runtime Library:

R6010

• abort() has been called
  (press Retry to debug the application)

It seems to me (only a guess, I usually just do web programming... :P) that the emulation thread is somehow not getting finished up or is not supposed to be finished by this point in the application...? In any case, I'm going to keep looking, but I'm a bit out of my depth here.

My specs, even though I doubt they matter all that much:

Windows 7 64bit
Intel i5-3570k (@ 4.0 GHz)
16 GB RAM
GeForce GTX 660

I have not had a chance to look at the code but will try and do so later today. I would agree that the thread is not exiting properly and that is the main cause for it's weird functionality once the application is closed from fullscreen.

This issue is caused by PR #2295, we're working on a solution.

Awesome! Thanks guys

Issue 8585 has been merged into this issue.

Issue 8590 has been merged into this issue.

Issue 8644 has been merged into this issue.

Issue 8634 has been merged into this issue.

Just out of curiosity, is there a regression test that is followed through before merging or pushing changes to master. This would resolve a few issues I have seen while using dolphin. I know this is not a company and is more freelance but still.... a proper process always helps!! thoughts?

Issue 8746 has been merged into this issue.

Since a proper fix will take some time and this is currently blocking the stable, I'm going to attempt to get the quick fix (PR #2538) merged. We'll deal with any threading issues that crop up during release candidate testing.