Project

General

Profile

Actions
Copy link

Emulator Issues #5725

closed

Use native full screen mode on OS X

Added by xuzz about 12 years ago. Updated over 3 years ago.

Status:
Fixed
Priority:
Normal
Assignee:
-
Category:
GFX
% Done:

0%

Operating system:
OS X
Issue type:
Feature request
Milestone:
Regression:
No
Relates to usability:
No
Relates to performance:
No
Easy:
No
Relates to maintainability:
No
Regression start:
Fixed in:

Description

Name of clone:
?

Purpose of code changes on this branch:
Switch Mac to use native full screen mode rather than taking over the current space and (really?) changing the system screen resolution. This introduces a dependency on OS X 10.7 Lion. Tested configuration options (automatically enter full screen mode; render to main window; others) and also hotkeys, and all work as expected. This also removes the now-superfluous "Fullscreen Resolution" video option (on OS X only).

When reviewing my code changes, please focus on:

  • Is depending on OS X 10.7 Lion or later acceptable? The statistics I've seen leave it and later with just over 50% market share, but it is only increasing. More technical users (e.g. those likely to be using Dolphin) likely have a higher adoption rate.
  • Is removing the "Fullscreen Resolution" option acceptable? This is now handled by the main resolution setting, as entering fullscreen is just equivalent to resizing the window.
  • Are there any other configurations or edge cases that I don't handle?

After the review, please pull into branch:
master

Related issues 1 (0 open — 1 closed)

Has duplicate Emulator - Emulator Issues #5754: Fullscreen mode crashes on Mac with HDMI Television set to 1080pDuplicate

Actions
Actions
Copy link

Also available in: Atom PDF