Project

General

Profile

Actions

Emulator Issues #6840

closed

Fix locale issues in shaders generators properly

Added by NeoBrainX over 10 years ago. Updated over 1 year ago.

Status:
Fixed
Priority:
Normal
Assignee:
-
% Done:

0%

Operating system:
N/A
Issue type:
Bug
Milestone:
Regression:
No
Relates to usability:
No
Relates to performance:
No
Easy:
No
Relates to maintainability:
Yes
Regression start:
Fixed in:

Description

Something is broken about our shader generators. degasus felt like working around issues by randomly changing unrelated code and instead of fixing the issue properly in revision 045efdfc3e558f1152b116574d92015f27e396fa.

Meanwhile, Rodolfo has come up with his own fix in revision 15b6d75b775eec17a5b8e05362f2e0ad6d7750e0 but seems to have no interest in upstreaming that change. I don't know if that change is a proper fix or just a hack as well.

Given that people seem to be okay with the idiocy that is currently happening in TextureConversionShader (instead of using "%f" in printf, degasus used "%d.0"...) I don't expect anyone to care about this issue, but it's something that should be fixed because.. ffs do I even need to explain this?

Actions

Also available in: Atom PDF