Emulator

Users will be really disappointed to find that this game is buggy.

Software Renderer has difficulty running this game, but in a fifolog if I pause on the right frame, I can see that the mouth is displayed correctly.

We should mark this Urgent.

Note: whoever fixes this makes me write about it in the progress report. Just putting that out there.

Is this still broken

Helios wrote:

Is this still broken

Likely yes. There are multiple issues around this, see #6833 and #10401.

I tested some fifologs (with a build from the past few days) and they still exhibit this issue. When I looked into it last year, it seemed like it was a texture issue where maybe our UVs were wrong.

Free shot to get into a progress report ya'll

I mean don't you want to be the one that fixed SEXY POKER in Dolphin? Is that not motivation enough?

When I render the fifolog the line is in a different position than the included images ie. CroppedMouth.
However I tracked it down to the following version.

Broken by 4.0-1474 -> https://dolphin-emu.org/download/dev/25f5598e31d5ce5dca8d1b03888a9205b616280e/

Resizing the window can make the seams disappear. That's odd

Please disregard my earlier bisect then. It affects behaviour but is not real cause of this issue.

These seams disappear by changing the rendered windows size regardless of the IR scale, so the issue lies elsewhere.

I have been messing around with this and the texture seam width seems to be proportional to the pixel center correction value. Normally it is set to 1/12 or 0.083 (https://bugs.dolphin-emu.org/issues/267#note-43) but lowering it shrinks the seams. At 0.03 they were almost gone and at 0.02 I couldn't see any seams. This also worked with this issue: https://bugs.dolphin-emu.org/issues/12426. It did create new lines in vp6 video's but those were fixed by https://github.com/dolphin-emu/dolphin/pull/9520 (which I think is mostly correct). Ultimately, the difference between realistic correction values and the values I tried is way too big to make sense. So it seems a single hard coded value isn't sufficient.

Having had a look at the texture seams issues I would advise to look at https://bugs.dolphin-emu.org/issues/10401 instead.

You can see there that there is colour in those seams of texture information of a neighboring sprite (lots of sprites in one file), so I think the fifolog supplied there is a much better place to look into the issue. I also looked at previous revisions of dolphin if they've affected the issue and I think they have 7a1744575d7569dd52739836685b6e6643ace61a (3.0-499) and lots of commits around that time affect the seam issues so I think it's in the ballpark of what the issue is.

3.0-498 rather

I think that issue is texture related and not vertex related. The changes that fixed these seams and these: https://bugs.dolphin-emu.org/issues/12426 didn't do anything to that issue. Also the software renderer doesn't have seams in sexy poker and sin and punishment while it does have the same problem in CNT. I tried changing the texture offset which changed the size of the seam CNT but caused other issues so I'm pretty sure that is not the way.

I believe these lines exist on console too, they're just different than on Dolphin.

You mean the CNT seams?

No the Sexy Poker ones.